https://bugzilla.redhat.com/show_bug.cgi?id=979749 --- Comment #2 from Josef Stribny <jstribny@xxxxxxxxxx> --- 1, "# I filed a bug on this upstream, but this works around it for now." In such cases. please always include the link to the upstream bug. 2, The package should BuildRequires: ruby(release) for >= f19 and BuildRequires: ruby(abi) for < f19 3, Please change BuildRequires of rubygem(timecop), rubygem(yard), rubygem(pry), ... to the new syntax: rubygem-timecop, rubygem-yard, rubygem-pry, ... 4, Don't use rake for running the test suite, ideally use MiniTest. See the guidelines [1] 5, Get rid of Bundler dependency as it's not needed and it's problematic to use in packages. 6, 'pry', 'coveralls', 'timecop' are listed as development dependencies... are they really needed for tests? I think if you delete those lines from the test suite, it will work without them. Less dependencies -> better. 7, Introduce -doc subpackage according to guidelines [1], separate files, mark %doc files, exclude gem cache and keep the rakefile: For main package: %files %dir %{gem_instdir} %{gem_libdir} %exclude %{gem_cache} %{gem_spec} %doc %{gem_instdir}/COPYRIGHT For -doc subpackage: %files doc %doc %{gem_instdir}/README.md %doc %{gem_docdir} %{gem_instdir}/Rakefile [1] https://fedoraproject.org/wiki/Packaging:Ruby?rd=Packaging/Ruby -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=XkfMvOEoT5&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review