[Bug 892314] Review Request: rubygem-unf_ext - Unicode Normalization Form support library for CRuby

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=892314



--- Comment #4 from Josef Stribny <jstribny@xxxxxxxxxx> ---
1, Description of -doc subpackage should end with a dot (.) according to
guidelines.

2, %doc    %{gem_instdir}/[A-Z]* seems too vague to me, please mention README
and LICENSE explicitly so it's clear that they are present.

3, Gemfile, Rakefile and original .gemspec could be kept in -doc for
clarification rather than excluded.

4, Keep the test suite in doc rather than excluding it.

Otherwise the package builds, installs and runs, rpmlint doesn't complain.
Please fix the issues 1, 2 and 4, and consider no. 3 so I can approve.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=SklFzUO6a3&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]