https://bugzilla.redhat.com/show_bug.cgi?id=880203 Josef Stribny <jstribny@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|package-review@lists.fedora | |project.org | Flags|needinfo?(jstribny@redhat.c | |om) | --- Comment #4 from Josef Stribny <jstribny@xxxxxxxxxx> --- Hi Ken, thanks for taking the review! > Would you mind unmarking "tests" as %doc? Sure, this is a mistake. > you should run "gem unpack" and "gem spec" in %prep, "gem build" in %build, etc. I will disagree with you here, %gem_install macro is completely sufficient and it's used this way in some gems. I am not patching anything, so those steps are redundant. But I moved it to %build, where it originally belongs. > update to the latest upstream Done. > and update the License field to "MIT" Good catch, changed. Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=5921913 SRPM: http://kojipkgs.fedoraproject.org//work/tasks/1914/5921914/rubygem-strong_parameters-0.2.1-1.fc19.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=PlPqofgCo5&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review