[Bug 880203] Review Request: rubygem-strong_parameters - Permitted and required parameters for Action Pack

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=880203

Ken Dreyer <ktdreyer@xxxxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ktdreyer@xxxxxxxxxxxx
           Assignee|nobody@xxxxxxxxxxxxxxxxx    |ktdreyer@xxxxxxxxxxxx
              Flags|                            |fedora-review?



--- Comment #2 from Ken Dreyer <ktdreyer@xxxxxxxxxxxx> ---
Hi Josef, I can take this review.

Would you mind unmarking "tests" as %doc? Also it looks like this package
should be updated for the latest Ruby guidelines. For example, you should run
"gem unpack" and "gem spec" in %prep, "gem build" in %build, etc.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=JuKZvqlMQF&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]