https://bugzilla.redhat.com/show_bug.cgi?id=1006197 Christopher Meng <cickumqt@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cickumqt@xxxxxxxxx --- Comment #1 from Christopher Meng <cickumqt@xxxxxxxxx> --- 1. I've edited the common rpmlint error solutions page: http://fedoraproject.org/wiki/Common_Rpmlint_issues#wrong-file-end-of-line-encoding Please avoid using dos2unix if possible. 2. %{_var} should be %{_localstatedir} 3. # polyglot file install -m 644 Book.bin $RPM_BUILD_ROOT%{_var}/lib/games/%{name} # the opening book install -m 644 polyglot.ini $RPM_BUILD_ROOT%{_var}/lib/games/%{name} missing -p option to preserve the timestamp. 4. Source1 should be: Source1: http://cl.ly/3x333m0G173F/download/%{name}-%{book_version}-book.zip 5. I've sent an email to website maintainer of stockfish, hope they can add a sourcetarball download link on the website. 6. No %{optflags} during compiling? I can see: debug = no optimize = yes (Research again contexts found: # optimize = yes/no --- (-O3/-fast etc.) --- Enable/Disable optimizations ?O.0?) 7. Why not use make install? 8. If one want to use your package on ppc(Peter Lemenkev), I think the installation way you've defined is not good. IMO upstream should use configure script to do that but actually not. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=XYBqQxGfBN&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review