https://bugzilla.redhat.com/show_bug.cgi?id=1000583 --- Comment #3 from Robin Lee <robinlee.sysu@xxxxxxxxx> --- Spec URL: http://cheeselee.fedorapeople.org/fcitx-anthy.spec SRPM URL: http://cheeselee.fedorapeople.org/fcitx-anthy-0.2.0-2.fc19.src.rpm Changes: - Own the diretory %%{_datadir}/fcitx/anthy/ - description enlarged (In reply to Christopher Meng from comment #2) > Directories without known owners: > > %{_datadir}/fcitx/anthy/*.sty > > ---> > > %{_datadir}/fcitx/anthy > > > =========== > > Suggestion: > > Name: fcitx-anthy > Version: 0.2.0 > Release: 1%{?dist} > Summary: Anthy Engine for Fcitx > Group: System Environment/Libraries > License: GPLv2+ > URL: https://fcitx-im.org/wiki/Anthy > Source0: http://download.fcitx-im.org/fcitx-anthy/%{name}-%{version}.tar.xz > BuildRequires: cmake > BuildRequires: fcitx-devel > BuildRequires: gettext > BuildRequires: intltool > BuildRequires: anthy-devel > Requires: fcitx > > Auh, a bit ugly... > > Name: fcitx-anthy > Version: 0.2.0 > Release: 1%{?dist} > Summary: Anthy Engine for Fcitx > Group: System Environment/Libraries > License: GPLv2+ > URL: https://fcitx-im.org/wiki/Anthy > Source0: http://download.fcitx-im.org/fcitx-anthy/%{name}-%{version}.tar.xz > BuildRequires: anthy-devel > BuildRequires: cmake > BuildRequires: fcitx-devel > BuildRequires: gettext > BuildRequires: intltool > Requires: fcitx The specfile is aligned with tabs. If you set tab as 4 spaces in you editor, you will get a cleanly aligned view. > > Also, %description is too short. > > Orig: > > Fcitx-anthy is an Anthy engine wrapper for Fcitx. It > provides a Japanese input method. > > > Mine: > > Fcitx-anthy is an Anthy engine wrapper for Fcitx based on scim-anthy. It > provides a Japanese input method. Users can input Japanese hiragana and > katakana by inputting romaji via fcitx-anthy. Fcitx-anthy can also convert > hiragana or katakana to Japanese kanji after inputting hiragana or katakana. OK. I have revised it with respect to your suggestion. > > ************************************* > > Please FIX the issue before SCM. > > APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=qzdioaYRVq&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review