[Bug 1005718] Review Request: faience-icon-theme - Faience icon theme

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1005718



--- Comment #2 from Wolfgang Ulbrich <chat-to-me@xxxxxxxxx> ---
(In reply to Mohamed El Morabity from comment #1)
> Hi,
> 
> some comments:
> 
> - expurging nonfree media files from the tarball is OK, but you should
> anyway document the way you drop those files from the original upstream
> tarball, as recommended by the guidelines:
Cool, will do.
>   
> http://fedoraproject.org/wiki/Packaging:
> SourceURL#When_Upstream_uses_Prohibited_Code
>   I had the same issue with one of my packages (light-themes), you can have
> a look at the script I embedded in my src.rpm to generate a "clean" tarball
> from the original one:
>   
> http://pkgs.fedoraproject.org/cgit/light-themes.git/tree/light-themes-
> generate-tarball.sh?h=f19
>    By the way, using a script will make easier future major updates of your
> package.
Thanks, i will try this to avoid this work again :)
> 
> - according to the index.theme files provided for each icon theme, Faience
> depends on Faenza, GNOME and hicolor themes for missing icons. As a result,
> you should add faenza-icon-theme and gnome-icon-theme as Requires
> (hicolor-icon-theme is already required by gnome-icon-theme).

I need to check this, but faenza-icon-theme is droped.
https://bugzilla.redhat.com/show_bug.cgi?id=1005176
For this reason i started this review, because i need faience or faenza for
mate-themes-extras.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=4MM23POhXL&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]