[Bug 1005504] Review Request: etcd - key value store package.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1005504

Peter Lemenkov <lemenkov@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lemenkov@xxxxxxxxx



--- Comment #2 from Peter Lemenkov <lemenkov@xxxxxxxxx> ---
Initial comments.

* Version field is wrong. You must use 0.1.1 (not "v0.1.1").

* You must mark LICENSE as %doc. Also you installed doc-files into versioned
doc-dir which is wrong since Fedora 20. I advise you to remove this line:

cp Documentation/* $RPM_BUILD_ROOT/usr/share/doc/%{name}-%{version}

and simply mark necessary files as %doc. E.g.

%doc LICENSE README.md Documentation/internal-protocol-versioning.md

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=xoMjdu323B&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]