https://bugzilla.redhat.com/show_bug.cgi?id=1005552 Jamie Nguyen <jamielinux@xxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|package-review@lists.fedora | |project.org | CC| |jamielinux@xxxxxxxxxxxxxxxx | |g Assignee|nobody@xxxxxxxxxxxxxxxxx |jamielinux@xxxxxxxxxxxxxxxx | |g Flags| |fedora-review? --- Comment #1 from Jamie Nguyen <jamielinux@xxxxxxxxxxxxxxxxx> --- Issues: ======= 1) BUNDLED: galette/includes/html2text.php This appears to be a fork of this EPL v1.0 licensed script: http://code.google.com/p/iaml/source/browse/trunk/org.openiaml.model.runtime/src/include/html2text/html2text.php If the original script can't be used, you'll need to open an FPC ticket and request a bundling exception. 2) BUNDLED: galette/includes/sql_parse.php This GPLv2+ licensed file appears to be bundled from the (obsolete?) phpBB 2.x branch. You'll need to open an FPC ticket and request a bundling exception. 3) BUNDLED: galette/includes/ca/cacert.crt This MPL v1.1 OR GPLv2+ OR LGPLv2+ licensed file is bundled from the mozilla source tree. How is this being used by galette? Is it not possible to use the system ca-certicates instead? 4) BUNDLED: galette/includes/jquery/* The MIT licensed jQuery is bundled. There are also numerous bundled jQuery plugins, several of which have no copyright or license header. (NB: There is a jQuery review request currently open: bz#857992 ) 5) BUNDLED: galette/lang/make_lang_l12n.py This GPL licensed software is bundled. This software probably needs to be packaged separately. 6) BUNDLED: galette/lang/xgettext.py This GPL licensed software is bundled. This software probably needs to be packaged separately. 7) BUNDLED: galette/templates/default/jquery-ui/* The MIT licensed jquery-ui-1.10.3.custom.css file is bundled, as well as several other png/gif files. Are these necessary for galette to function normally? Can they be removed? 8) https://fedoraproject.org/wiki/Packaging:Guidelines#Documentation Documentation sub-package is recommended to be called %{name}-doc and should have "Group: Documentation" tag. 9) SELinux file contexts. I couldn't find official guidelines, but the SELinux file contexts that galette requires should be put into the system SELinux policy, instead of running semanage/restorecon in the package scriplets. Please open a bug report against selinux-policy with a complete list of the required file contexts. The maintainers will probably prefer that you open separate bugs for every required branch. You can then remove the selinux dependencies (which pull in a lot if the admin has removed selinux on their server, as unwise as that may be) and installation/removal of galette will be faster. 10) Restarting httpd The package is restarting httpd in the post/postun scriptlets. I couldn't find guidelines about this, but I think these scriptlets should be removed. I'm not aware of any other web applications that restart httpd. 11) rpmlint galette.noarch: W: spelling-error %description -l fr d'identifiants -> t'identifiant, s'identifiant, t'identifiât galette.noarch: W: conffile-without-noreplace-flag /etc/galette/versions.inc.php galette.noarch: E: non-executable-script /usr/share/galette/post_contribution_test.php 0644L /usr/bin/php galette.noarch: W: dangerous-command-in-%preun rm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=BiDlqZYgMg&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review