https://bugzilla.redhat.com/show_bug.cgi?id=920310 Christopher Meng <cickumqt@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cickumqt@xxxxxxxxx, | |rclark@xxxxxxxxxx Flags| |needinfo?(rclark@xxxxxxxxxx | |) --- Comment #3 from Christopher Meng <cickumqt@xxxxxxxxx> --- 1. Use tags. https://github.com/apitrace/apitrace/releases So please also modify Source0 URL. 2. Remove %defattr(-,root,root,-) 3. Wrong: %dir %{_libdir}/apitrace/wrappers %{_libdir}/apitrace/wrappers %{_libdir}/apitrace/wrappers/glxtrace.so %{_libdir}/apitrace/wrappers/egltrace.so %dir %{_libdir}/apitrace/scripts %{_libdir}/apitrace/scripts/highlight.py %{_libdir}/apitrace/scripts/unpickle.pyo %{_libdir}/apitrace/scripts/tracecheck.py %{_libdir}/apitrace/scripts/snapdiff.py %{_libdir}/apitrace/scripts/highlight.pyo %{_libdir}/apitrace/scripts/profileshader.py %{_libdir}/apitrace/scripts/tracediff.pyo %{_libdir}/apitrace/scripts/snapdiff.pyc %{_libdir}/apitrace/scripts/tracecheck.pyc %{_libdir}/apitrace/scripts/tracediff.py %{_libdir}/apitrace/scripts/jsondiff.pyo %{_libdir}/apitrace/scripts/retracediff.py %{_libdir}/apitrace/scripts/tracecheck.pyo %{_libdir}/apitrace/scripts/jsondiff.pyc %{_libdir}/apitrace/scripts/retracediff.pyc %{_libdir}/apitrace/scripts/retracediff.pyo %{_libdir}/apitrace/scripts/profileshader.pyc %{_libdir}/apitrace/scripts/unpickle.pyc %{_libdir}/apitrace/scripts/jsondiff.py %{_libdir}/apitrace/scripts/profileshader.pyo %{_libdir}/apitrace/scripts/tracediff.pyc %{_libdir}/apitrace/scripts/unpickle.py %{_libdir}/apitrace/scripts/highlight.pyc %{_libdir}/apitrace/scripts/snapdiff.pyo First, these files shouldn't be installed to libdir. Please use %python_sitearch, not %python_sitelib. ---------- %dir %{_datadir}/doc/apitrace %{_datadir}/doc/apitrace/LICENSE-snappy.txt %{_datadir}/doc/apitrace/LICENSE-zlib.txt %{_datadir}/doc/apitrace/NEWS.markdown %{_datadir}/doc/apitrace/BUGS.markdown %{_datadir}/doc/apitrace/LICENSE.txt %{_datadir}/doc/apitrace/LICENSE-libpng.txt %{_datadir}/doc/apitrace/LICENSE-qjson.txt %{_datadir}/doc/apitrace/README.markdown These are wrong, too. Use %doc to mark them, don't write down in the %files with full path. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=9Bp2LEtXIn&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review