https://bugzilla.redhat.com/show_bug.cgi?id=927374 Troy Dawson <tdawson@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|package-review@lists.fedora | |project.org | --- Comment #17 from Troy Dawson <tdawson@xxxxxxxxxx> --- Spec URL: http://tdawson.fedorapeople.org/review/rubygem-rugged.spec SRPM URL: http://tdawson.fedorapeople.org/review/rubygem-rugged-0.19.0-3.fc20.src.rpm - Added version to ruby(abi) - Added %{?rubygems_default_filter} before description - Added BR: git -- didn't use /usr/bin/git because that would break on older Fedora versions - Removed line where I was removing hidden files - Added full test directory from github (Source1) -- In comments say how I get and package Source1 -- Let developers know of gemspec bug, they have already thanked me and said they will fix it. - Remove BR: rubygem(test-unit) - Fix up tests so they all pass -- Added LANG variable -- run "git config --global user.name John Doe" Thanks for the help with the tests. I would have never found those missing directories, and switching to minitest fixed the exit code problem. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=ecUMWRjY2c&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review