[Bug 1004963] Review Request: openstack-heat-templates - Heat example templates and DIB elements

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1004963

Jamie Nguyen <jamielinux@xxxxxxxxxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|package-review@lists.fedora |
                   |project.org                 |
             Status|NEW                         |ASSIGNED
                 CC|                            |jamielinux@xxxxxxxxxxxxxxxx
                   |                            |g
           Assignee|nobody@xxxxxxxxxxxxxxxxx    |jamielinux@xxxxxxxxxxxxxxxx
                   |                            |g



--- Comment #1 from Jamie Nguyen <jamielinux@xxxxxxxxxxxxxxxxx> ---
Issues:
=======

1) Please add a URL tag.

2) Please use the GitHub Source URL guidelines:
https://fedoraproject.org/wiki/Packaging:SourceURL#Github

3) This is a pre-release package (as upstream have not made any releases yet),
so please use the snapshot package guidelines and pre-release package naming
guidelines:
https://fedoraproject.org/wiki/Packaging:NamingGuidelines#Snapshot_packages
https://fedoraproject.org/wiki/Packaging:NamingGuidelines#Pre-Release_packages

4) There is no version indicated upstream, and I can't find any indication that
'0.0.1' will be the version they will start with. Start versioning from '0'
instead, so something like openstack-heat-templates-0-0.1.20130813git. Upstream
might start from version '0.0.0', in which case '0.0.1' will be newer than
upstream.

5) The files are not purely documentation files and include shell scripts.
%{_datadir}/%{name} is probably a better location.

6) There are no %build or %install sections. These aren't compulsory, but it's
common practice to include them anyway even if you're not running any commands
inside them. It'll also silence the rpmlint warnings. This is not a MUST
though, so I won't block the review on this.

7) I'd say openshift-origin/ directory should be put into a separate subpackage
possibly called openshift-origin-templates.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=x5CoxMlZsT&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]