https://bugzilla.redhat.com/show_bug.cgi?id=1004845 --- Comment #8 from Björn "besser82" Esser <bjoern.esser@xxxxxxxxx> --- Some general comments on the spec-file: * Use of %define: %define upstream_version 3.1.2 %define upstream_release 1 Use %global instead of %define. See: http://fedoraproject.org/wiki/Packaging:Guidelines#.25global_preferred_over_.25define * no %check, though there's a testsuite in sources: BuildRequires: swig %check %{__python} tests.py http://code.google.com/p/python-libarchive/wiki/Building * What are these used for? %global upstream_name python-libarchive %global module_name libarchive * Use the macro you define more common: Version: %{upstream_version}.%{upstream_release} * no proper export of compiler-flags before build: Add "%configure ||:" on top inside %build There might be more issues, this just came from quick glance over the spec. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=UjX8LkYrES&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review