https://bugzilla.redhat.com/show_bug.cgi?id=1004257 Parag AN(पराग) <panemade@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|package-review@lists.fedora | |project.org | --- Comment #6 from Parag AN(पराग) <panemade@xxxxxxxxx> --- Review:- + package builds fine in mock (f21) - rpmlint output on rpms gave python3-pudb.noarch: E: non-executable-script /usr/lib/python3.3/site-packages/pudb/debugger.py 0644L /usr/bin/env python3-pudb.noarch: W: no-manual-page-for-binary pudb3 python-pudb.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/pudb/debugger.py 0644L /usr/bin/env python-pudb.noarch: W: no-manual-page-for-binary pudb 3 packages and 0 specfiles checked; 2 errors, 2 warnings. + Source verified with upstream as (sha256sum) tarball in srpm : 3f99f6f1d85808f6f17ee86a2bb28845e86c9bb3e72868d6bfe10ef7e22bcfff tarball from upstream : 3f99f6f1d85808f6f17ee86a2bb28845e86c9bb3e72868d6bfe10ef7e22bcfff + License is "MIT" and there is license text in any source file or own license text file. Suggestions: 1) I assume you are not building this package on el5 and el6, so remove invalid buildroot. See http://fedoraproject.org/wiki/Packaging/Guidelines#BuildRoot_tag 2) I assume you are not building this package on el5 and el6, so remove following from spec as its not needed anymore in Fedora %if ! (0%{?rhel} > 5) %{!?python_sitelib: %global python_sitelib %(%{__python} -c "from distutils.sysconfig import get_python_lib; print(get_python_lib())")} %endif If you want to build for EPEL then keep above. 3) BuildRequires: python-devel should be changed to python2-devel See https://fedoraproject.org/wiki/:Python#BuildRequires 4) rpmlint output is showing non-executable-script error. To fix this add following line in %prep but before copying to py3dir sed -i '1{\@^#! /usr/bin/env python@d}' pudb/debugger.py 5) I don't think you will need to write explicitly attr(0755, root, root) for /usr/bin/pudb. Remove attr(). 6) source package does not include license text as a separate file from upstream, the packager SHOULD query upstream to include it. Please bump the release tag when you will fix above issues and submit a new srpm. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=PgbqdTX9Zt&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review