https://bugzilla.redhat.com/show_bug.cgi?id=1004094 --- Comment #1 from Christopher Meng <cickumqt@xxxxxxxxx> --- Improvement: 1. Avoid attr() nowadays. Please correc its permission when installing it: install -pm755 cups-x2go %{buildroot}%{_prefix}/lib/cups/backend/ 2. Drop %doc as it doesn't exist. 3. %{_sysconfdir}/cups/cups-x2go.conf should be added %config(noreplace) 4. New Fedora Review tool is very nice, it told me that you shouldn't own a dir already taken by other packages: [!]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /usr/share/x2go(x2goserver), /usr/share/x2go/versions(x2goserver) So you should correct %{_datadir}/x2go/. 5. cups-x2go.noarch: W: non-standard-group Server So, fix it or drop the group tag. 6. cups-x2go.src:11: W: mixed-use-of-spaces-and-tabs (spaces: line 11, tab: line 1) -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=lgoUlRgHbZ&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review