Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: eclipse-mylar - A task-focused UI for Eclipse https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=232725 ------- Additional Comments From fitzsim@xxxxxxxxxx 2007-03-19 18:43 EST ------- MUST: * package is named appropriately * it is legal for Fedora to distribute this * license field matches the actual license. * license is open source-compatible. * specfile name matches %{name} ? source and patches verified - eclipse projects don't release source tarballs, right? - the tarball creation steps worked, but an md5sum on the result didn't match the source tarball. Maybe the "tarball recipe" could be modified to always produce a tarball with the same md5sum, perhaps by sorting the files list and manipulating timestamps... - should there be a URL tag pointing to the Mylar project home page? X summary and description okay - see rpmlint comments * correct buildroot * %{?dist} used properly * license text included in package and marked with %doc * packages meets FHS (http://www.pathname.com/fhs/) X rpmlint on <this package>.srpm gives no output - $ rpmlint eclipse-mylar-1.0-1.src.rpm E: eclipse-mylar description-line-too-long and offline editing for repositories such as Bugzilla, Trac, and JIRA. Once your E: eclipse-mylar description-line-too-long relevant to the task-at-hand, and uses this task context to focus the Eclipse UI E: eclipse-mylar description-line-too-long navigation. By making task context explicit Mylar also facilitates multitasking, W: eclipse-mylar non-standard-group Eclipse Plugins W: eclipse-mylar invalid-license EPL W: eclipse-mylar no-url-tag W: eclipse-mylar strange-permission fetch-mylar.sh 0600 I agree with rpmlint that these things should be fixed. * changelog fine * Packager tag not used * Vendor tag not used * Distribution tag not used * License and not Copyright used * Summary tag does not end in a period * if possible, replace PreReq with Requires(pre) and/or Requires(post) ? specfile is legible - are all those Requires and Provides commented because of the missing dependencies in Rawhide, or some other reason? * package successfully compiles and builds on at least x86 X BuildRequires are proper - commented out BuildRequires explained in bugzilla comments: OK - since you explicitly use the eclipse binary in %build, I'd like to see an explicit BuildRequires on its provider, eclipse-platform (even though it's brought in indirectly by eclipse-pde) * summary is a short and concise description of the package * description expands upon summary * make sure lines are <= 80 characters - is your editor set to wrap after column 80 (zero-indexed) instead of after 79 (zero-indexed)? - the %build an %install indenting is inconsistent (not a big deal) * specfile written in American English * no -doc sub-package necessary * no static libs * no rpath * config files should marked with %config(noreplace) * not a GUI app * sub-packages fine X macros used appropriately and consistently - %{buildroot} vs. $RPM_BUILD_ROOT * %makeinstall not used * no locale data * Requires(pre,post) fine * package not relocatable * package contains code * package owns all directories and files * no %files duplicates ? file permissions okay; %defattrs present - why do you explicitly state the first and last defattrs sets, rather than just using '-'? * %clean present ? %doc files do not affect runtime - the doc files are in the features directory -- are they displayed by a GUI window or otherwise used in a way that would break if they weren't there? * not a webapp ? verify the final provides and requires of the binary RPMs - will have to verify this when the package builds SHOULD: * package should include license text in the package and mark it with %doc X package should build on x86_64 I'm getting this build failure: + eclipse -nosplash -application org.eclipse.ant.core.antRunner -Dtype=feature -Did=org.eclipse.mylar_feature -DbaseLocation=/home/fitzsim/rpmbuild/BUILD/org.eclipse.mylar/SDK -DsourceDirectory=/home/fitzsim/rpmbuild/BUILD/org.eclipse.mylar -DbuildDirectory=/home/fitzsim/rpmbuild/BUILD/org.eclipse.mylar/build -Dbuilder=/usr/share/eclipse/plugins/org.eclipse.pde.build/templates/package-build -f /usr/share/eclipse/plugins/org.eclipse.pde.build/scripts/build.xml -vmargs -Duser.home=/home/fitzsim/rpmbuild/BUILD/org.eclipse.mylar/home -DJ2SE-1.5=/usr/lib/jvm/java/jre/lib/rt.jar (eclipse:9246): Gtk-WARNING **: cannot open display: error: Bad exit status from /var/tmp/rpm-tmp.87465 (%build) RPM build errors: Bad exit status from /var/tmp/rpm-tmp.87465 (%build) on a Rawhide x86_64 machine. ? package should build in mock -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review