https://bugzilla.redhat.com/show_bug.cgi?id=929254 Petr Pisar <ppisar@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #8 from Petr Pisar <ppisar@xxxxxxxxxx> --- Spec file changes: --- perl-Module-CPANfile.spec 2013-08-27 16:43:42.000000000 +0200 +++ perl-Module-CPANfile.spec.1 2013-08-30 15:53:23.000000000 +0200 @@ -1,6 +1,6 @@ Name: perl-Module-CPANfile Version: 1.0001 -Release: 2%{?dist} +Release: 3%{?dist} Summary: Parse cpanfile License: GPL+ or Artistic Group: Development/Libraries @@ -14,6 +14,7 @@ BuildRequires: perl(CPAN::Meta) >= 2.12091 BuildRequires: perl(CPAN::Meta::Prereqs) >= 2.12091 BuildRequires: perl(CPAN::Meta::Feature) >= 2.12091 +BuildRequires: perl(Data::Dumper) BuildRequires: perl(ExtUtils::MakeMaker) >= 6.30 BuildRequires: perl(strict) BuildRequires: perl(warnings) @@ -21,14 +22,13 @@ BuildRequires: perl(Exporter) BuildRequires: perl(POSIX) BuildRequires: perl(Test::More) >= 0.88 -BuildRequires: perl(Pod::Usage) Requires: perl(CPAN::Meta) >= 2.12091 Requires: perl(CPAN::Meta::Prereqs) >= 2.12091 Requires: perl(CPAN::Meta::Feature) >= 2.12091 Requires: perl(Data::Dumper) Requires: perl(Pod::Usage) -Requires: perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo $version)) +Requires: perl(:MODULE_COMPAT_%(eval "`perl -V:version`"; echo $version)) %?perl_default_filter %global __requires_exclude %{?__requires_exclude:%__requires_exclude|}perl\\(CPAN::Meta\\)$ @@ -62,6 +62,9 @@ %{_mandir}/man3/* %changelog +* Fri Aug 30 2013 Marcela Mašláňová <mmaslano@xxxxxxxxxx> 1.0001-3 +- fix all problems found in review rhbz#929254 + * Tue Aug 27 2013 Marcela Mašláňová <mmaslano@xxxxxxxxxx> 1.0001-2 - fix all problems found in review rhbz#929254 > > TODO: You can use plain `perl' instead of macro `%{__perl}'. > TODO: You can do that same at perl(:MODULE_COMPAT) definition. -Requires: perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo $version)) +Requires: perl(:MODULE_COMPAT_%(eval "`perl -V:version`"; echo $version)) Ok. > > FIX: Build-require `perl(Data::Dumper)' (lib/Module/CPANfile.pm:115). > FIX: still issue. +BuildRequires: perl(Data::Dumper) Ok. > > FIX: Do not build-require `perl(Pod::Usage)'. It's not needed at build-time. > FIX: still issue. -BuildRequires: perl(Pod::Usage) Ok. $ rpmlint perl-Module-CPANfile.spec ../SRPMS/perl-Module-CPANfile-1.0001-3.fc21.src.rpm ../RPMS/noarch/perl-Module-CPANfile-1.0001-3.fc21.noarch.rpm 2 packages and 1 specfiles checked; 0 errors, 0 warnings. rpmlint is Ok. Package builds in F21 (http://koji.fedoraproject.org/koji/taskinfo?taskID=5880768). Ok. Package is good. Resolution: Package APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Sd4oKfWEd8&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review