[Bug 929254] Review Request: perl-Module-CPANfile - Parse cpanfile

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=929254



--- Comment #6 from Petr Pisar <ppisar@xxxxxxxxxx> ---
Spec file changes:

--- perl-Module-CPANfile.spec   2013-08-27 12:38:33.000000000 +0200
+++ perl-Module-CPANfile.spec.1 2013-08-27 16:43:42.000000000 +0200
@@ -1,27 +1,38 @@
 Name:           perl-Module-CPANfile
 Version:        1.0001
-Release:        1%{?dist}
+Release:        2%{?dist}
 Summary:        Parse cpanfile
 License:        GPL+ or Artistic
 Group:          Development/Libraries
 URL:            http://search.cpan.org/dist/Module-CPANfile/
 Source0:       
http://www.cpan.org/authors/id/M/MI/MIYAGAWA/Module-CPANfile-%{version}.tar.gz
 BuildArch:      noarch
+BuildRequires:  perl
+BuildRequires:  perl(base)
 BuildRequires:  perl(Carp)
 BuildRequires:  perl(Cwd)
 BuildRequires:  perl(CPAN::Meta) >= 2.12091
 BuildRequires:  perl(CPAN::Meta::Prereqs) >= 2.12091
 BuildRequires:  perl(CPAN::Meta::Feature) >= 2.12091
-BuildRequires:  perl(ExtUtils::MakeMaker)
+BuildRequires:  perl(ExtUtils::MakeMaker) >= 6.30
+BuildRequires:  perl(strict)
+BuildRequires:  perl(warnings)
 # tests
 BuildRequires:  perl(Exporter)
 BuildRequires:  perl(POSIX)
 BuildRequires:  perl(Test::More) >= 0.88
 BuildRequires:  perl(Pod::Usage)

+Requires:       perl(CPAN::Meta) >= 2.12091
 Requires:       perl(CPAN::Meta::Prereqs) >= 2.12091
+Requires:       perl(CPAN::Meta::Feature) >= 2.12091
+Requires:       perl(Data::Dumper)
+Requires:       perl(Pod::Usage)
 Requires:       perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo
$version))

+%?perl_default_filter
+%global __requires_exclude
%{?__requires_exclude:%__requires_exclude|}perl\\(CPAN::Meta\\)$
+
 %description
 Module::CPANfile is a tool to handle cpanfile format to load application
 specific dependencies, not just for CPAN distributions.
@@ -30,14 +41,13 @@
 %setup -q -n Module-CPANfile-%{version}

 %build
-%{__perl} Makefile.PL INSTALLDIRS=vendor
+perl Makefile.PL INSTALLDIRS=vendor
 make %{?_smp_mflags}

 %install
 make pure_install PERL_INSTALL_ROOT=$RPM_BUILD_ROOT

 find $RPM_BUILD_ROOT -type f -name .packlist -exec rm -f {} \;
-find $RPM_BUILD_ROOT -depth -type d -exec rmdir {} 2>/dev/null \;

 %{_fixperms} $RPM_BUILD_ROOT/*

@@ -45,12 +55,15 @@
 make test

 %files
-%doc Changes cpanfile dist.ini LICENSE META.json README
+%doc Changes LICENSE README
 %{_bindir}/mymeta-cpanfile
 %{perl_vendorlib}/*
 %{_mandir}/man1/mymeta-cpanfile*
 %{_mandir}/man3/*

 %changelog
+* Tue Aug 27 2013 Marcela Mašláňová <mmaslano@xxxxxxxxxx> 1.0001-2
+- fix all problems found in review rhbz#929254
+
 * Tue Aug 27 2013 Marcela Mašláňová <mmaslano@xxxxxxxxxx> 1.0001-1
 - Specfile autogenerated by cpanspec 1.78.


> TODO: You can use plain `perl' instead of macro `%{__perl}'.
TODO: You can do that same at perl(:MODULE_COMPAT) definition.

> TODO: You can remove deleting empty directories in the %install section.
> These are not created anymore.
-find $RPM_BUILD_ROOT -depth -type d -exec rmdir {} 2>/dev/null \;
Ok.

> TODO: Do not package cpanfile, dist.ini. They do not contain any data relevant
> to an user. META.json is questionable. It lists all contributors and git
> repository link.
-%doc Changes cpanfile dist.ini LICENSE META.json README
+%doc Changes LICENSE README
Ok.

> TODO: Constrain `perl(ExtUtils::MakeMaker)' build-dependency with `>= 6.30'
> (Makefile.PL:7).
-BuildRequires:  perl(ExtUtils::MakeMaker)
+BuildRequires:  perl(ExtUtils::MakeMaker) >= 6.30
Ok.

> TODO: Build-require `perl(strict)' (Makefile.PL:2).
+BuildRequires:  perl(strict)
Ok.

> TODO: Build-require `perl(warnings)' (Makefile.PL:3).
+BuildRequires:  perl(warnings)
Ok.

> FIX: Build-require `perl(Data::Dumper)' (lib/Module/CPANfile.pm:115).
FIX: still issue.

> TODO: Build-require `perl(base)' (t/Utils.pm:2).
+BuildRequires:  perl(base)
Ok.

> FIX: Do not build-require `perl(Pod::Usage)'. It's not needed at build-time.
FIX: still issue.

> FIX: Constrain `perl(CPAN::Meta)' run-dependency with `>= 2.12091'.
+Requires:       perl(CPAN::Meta) >= 2.12091
Ok.

> FIX: Run-require `perl(CPAN::Meta::Feature) >= 2.12091'
> (lib/Module/CPANfile.pm:63).
+Requires:       perl(CPAN::Meta::Feature) >= 2.12091
Ok.

> FIX: Run-require `perl(Data::Dumper)' (lib/Module/CPANfile.pm:115).
+Requires:       perl(Data::Dumper)
Ok.

> FIX: Run-require `perl(Pod::Usage)' (script/mymeta-cpanfile:20).
+Requires:       perl(Pod::Usage)
Ok.

$ rpmlint perl-Module-CPANfile.spec
../SRPMS/perl-Module-CPANfile-1.0001-2.fc21.src.rpm
../RPMS/noarch/perl-Module-CPANfile-1.0001-2.fc21.noarch.rpm 
2 packages and 1 specfiles checked; 0 errors, 0 warnings.
rpmlint is Ok.

$ rpm -q --requires -p
../RPMS/noarch/perl-Module-CPANfile-1.0001-2.fc21.noarch.rpm | sort | uniq -c
      1 /usr/bin/perl
      1 perl(:MODULE_COMPAT_5.18.1)
      1 perl(CPAN::Meta) >= 2.12091
      1 perl(CPAN::Meta::Feature) >= 2.12091
      1 perl(CPAN::Meta::Prereqs) >= 2.12091
      1 perl(Carp)
      1 perl(Cwd)
      1 perl(Data::Dumper)
      1 perl(Getopt::Long)
      1 perl(Module::CPANfile)
      1 perl(Module::CPANfile::Environment)
      1 perl(Module::CPANfile::Result)
      1 perl(Pod::Usage)
      1 perl(strict)
      1 perl(warnings)
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
Binary requires are Ok.

$ resolvedeps rawhide
../RPMS/noarch/perl-Module-CPANfile-1.0001-2.fc21.noarch.rpm 
Binary dependencies resolvable. Ok.

Package builds in F21
(http://koji.fedoraproject.org/koji/taskinfo?taskID=5873225). Ok.

Please correct all `FIX' issues, consider fixing `TODO' items, and provide new
spec file.

Resolution: Package NOT approved.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=DJE4wrjsOD&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]