https://bugzilla.redhat.com/show_bug.cgi?id=951827 Elad Alfassa <el.il@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|package-review@lists.fedora | |project.org | --- Comment #2 from Elad Alfassa <el.il@xxxxxxxxxx> --- (In reply to Luya Tshimbalanga from comment #1) > Hello Elad, > > Quick review: > - remove rm -fr %{buildroot} within #install > - %clean section is not required in F13 and above according to > https://fedoraproject.org/wiki/Packaging:Guidelines#.25clean Right. Will fix soon. > - Why BuildRequires: dos2unix? Upstream shipped the OFL-license.txt file with DOS line endings. rpmlint will complain if the package has files with DOS line endings. dos2unix converts DOS line endings to unix line endings. > - Why including OFL-license.txt in %build section? Does it really matter if it's in build or prep? > - rpmlint generated two warnings: > > alef-fonts.noarch: W: spelling-error Summary(en_US) multi -> mulch, mufti > alef-fonts.noarch: W: spelling-error %description -l en_US multi -> mulch, > mufti > > Both Summary and %description should use US English: multi-lingual should be > multilingual. That's a nitpick, but okay, will do. > > - Add %_font_pkg -f %{fontconf} *.ttf after this line > ln -s %{_fontconfig_templatedir}/%{fontconf} \ > %{buildroot}%{_fontconfig_confdir}/%{fontconf} I already have this line, you didn't notice it because it's after %clean Thanks for the review. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=PAi9zSRnpK&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review