[Bug 1002013] Review Request: httpdtap - Tool for querying httpd using SystemTap scripts

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1002013

Mario Blättermann <mario.blaettermann@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|package-review@lists.fedora |
                   |project.org                 |
             Status|NEW                         |ASSIGNED
           Assignee|nobody@xxxxxxxxxxxxxxxxx    |mario.blaettermann@xxxxxxxx
                   |                            |m
              Flags|                            |fedora-review?



--- Comment #3 from Mario Blättermann <mario.blaettermann@xxxxxxxxx> ---
Scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=5870630

$ rpmlint -i -v *
httpdtap.src: I: checking
httpdtap.src: W: spelling-error Summary(en_US) httpd -> HTTP
The value of this tag appears to be misspelled. Please double-check.

httpdtap.src: W: spelling-error %description -l en_US httpd -> HTTP
The value of this tag appears to be misspelled. Please double-check.

httpdtap.src: I: checking-url https://github.com/hanzz/httpdtap (timeout 10
seconds)
httpdtap.src: I: checking-url
https://github.com/hanzz/httpdtap/archive/v0.1.tar.gz (timeout 10 seconds)
httpdtap.noarch: I: checking
httpdtap.noarch: E: devel-dependency apr-debuginfo
Your package has a dependency on a devel package but it's not a devel package
itself.

httpdtap.noarch: W: spelling-error Summary(en_US) httpd -> HTTP
The value of this tag appears to be misspelled. Please double-check.

httpdtap.noarch: W: spelling-error %description -l en_US httpd -> HTTP
The value of this tag appears to be misspelled. Please double-check.

httpdtap.noarch: I: checking-url https://github.com/hanzz/httpdtap (timeout 10
seconds)
httpdtap.noarch: E: non-executable-script
/usr/share/httpdtap/scripts-24/req_time.stp 0644L /usr/bin/env
This text file contains a shebang or is located in a path dedicated for
executables, but lacks the executable bits and cannot thus be executed.  If
the file is meant to be an executable script, add the executable bits,
otherwise remove the shebang or move the file elsewhere.

httpdtap.noarch: E: non-executable-script
/usr/share/httpdtap/scripts-22/req_from.stp 0644L /usr/bin/env
This text file contains a shebang or is located in a path dedicated for
executables, but lacks the executable bits and cannot thus be executed.  If
the file is meant to be an executable script, add the executable bits,
otherwise remove the shebang or move the file elsewhere.

httpdtap.noarch: E: non-executable-script
/usr/share/httpdtap/scripts-24/req_files.stp 0644L /usr/bin/env
This text file contains a shebang or is located in a path dedicated for
executables, but lacks the executable bits and cannot thus be executed.  If
the file is meant to be an executable script, add the executable bits,
otherwise remove the shebang or move the file elsewhere.

httpdtap.noarch: E: non-executable-script
/usr/share/httpdtap/scripts-22/req_files.stp 0644L /usr/bin/env
This text file contains a shebang or is located in a path dedicated for
executables, but lacks the executable bits and cannot thus be executed.  If
the file is meant to be an executable script, add the executable bits,
otherwise remove the shebang or move the file elsewhere.

httpdtap.noarch: E: non-executable-script
/usr/share/httpdtap/scripts-22/req_time.stp 0644L /usr/bin/env
This text file contains a shebang or is located in a path dedicated for
executables, but lacks the executable bits and cannot thus be executed.  If
the file is meant to be an executable script, add the executable bits,
otherwise remove the shebang or move the file elsewhere.

httpdtap.noarch: E: non-executable-script
/usr/share/httpdtap/scripts-24/req_slower_than.stp 0644L /usr/bin/env
This text file contains a shebang or is located in a path dedicated for
executables, but lacks the executable bits and cannot thus be executed.  If
the file is meant to be an executable script, add the executable bits,
otherwise remove the shebang or move the file elsewhere.

httpdtap.noarch: E: non-executable-script
/usr/share/httpdtap/scripts-22/req_slower_than.stp 0644L /usr/bin/env
This text file contains a shebang or is located in a path dedicated for
executables, but lacks the executable bits and cannot thus be executed.  If
the file is meant to be an executable script, add the executable bits,
otherwise remove the shebang or move the file elsewhere.

httpdtap.noarch: E: non-executable-script
/usr/share/httpdtap/scripts-24/req_from.stp 0644L /usr/bin/env
This text file contains a shebang or is located in a path dedicated for
executables, but lacks the executable bits and cannot thus be executed.  If
the file is meant to be an executable script, add the executable bits,
otherwise remove the shebang or move the file elsewhere.

httpdtap.noarch: W: no-manual-page-for-binary httpdtap
Each executable in standard binary directories should have a man page.

httpdtap.spec: I: checking-url
https://github.com/hanzz/httpdtap/archive/v0.1.tar.gz (timeout 10 seconds)
2 packages and 1 specfiles checked; 9 errors, 5 warnings.


The devel-dependency warnings are false positive.

What about the non-executable scripts? They should have the executable bit, as
far as I can see, unless the scripts are actually modules which will be always
called from another script. In the latter case, remove the shebang.

Since you are the upstream author, does it make sense to add man pages to the
executable Python script? Maybe with help2man, that's the simplest way in case
it has the option --help.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=HDKxN5rE7I&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]