https://bugzilla.redhat.com/show_bug.cgi?id=1002324 Christopher Meng <cickumqt@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cickumqt@xxxxxxxxx --- Comment #1 from Christopher Meng <cickumqt@xxxxxxxxx> --- SPEC invalid. 1. Let's see the perl file itself: Quoted: use strict; # core use version; # core use FileHandle; # core use Getopt::Long; # core use File::Basename; # core use Digest::file; # core use Digest::SHA qw(sha256); # core use Data::Dumper qw(Dumper); # core use Term::ReadLine; # core use Term::ANSIColor; # core use Carp qw(longmess); # core use Time::HiRes qw(gettimeofday tv_interval); # core use POSIX; # core, required for unsafe signal handling use Crypt::Rijndael; # non-core, libcrypt-rijndael-perl on Ubuntu use Sort::Naturally; # non-core, libsort-naturally-perl on Ubuntu use Term::ReadKey; # non-core, libterm-readkey-perl on Ubuntu use Term::ShellUI; # non-core, libterm-shellui-perl on Ubuntu # - add Term::ReadLine::Gnu for cli history use File::KeePass 0.03; # non-core, libfile-keepass-perl on Ubuntu # - >=v0.03 needed due critical bug fixes So, it needs a lot of dependencies. And you may ask, should I write it in the spec? Then let's see back to your another spec: http://fedorapeople.org/~delete/kpcli/perl-Term-ShellUI.spec We can see a line: Requires: perl(:MODULE_COMPAT_%(eval "`perl -V:version`"; echo $version)) So this is the magic, when you add this as "Requires", RPM dependencies generator will look into the perl file and then automatically add requires when installing it. But sometimes it also ca make mistakes, so if RPM can't cover all dependencies during deps check, then you should add missing ones to the SPEC. ALSO, Requires: perl-Term-ReadLine-Gnu should be corrected. 2. %description: KeePass Command Line Interface (CLI) / interactive shell. Use this program to access and manage your KeePass 1.x or 2.x databases from a Unix-like command line You should add a dot at the end of these texts, and you shouldn't leave a space: 2.x databases from a Unix-like command line should be: 2.x databases from a Unix-like command line 3. %install: install -d %{buildroot}/%{_bindir}/ install -m 0755 %{name}-%{version}.pl %{buildroot}/%{_bindir}/%{name} You didn't preserve the timestamp. Suggestion: mkdir %{buildroot}%{_bindir}/ install -pm0755 %{name}-%{version}.pl %{buildroot}%{_bindir}/%{name} And, you can remove the common slash when writing such paths: %{buildroot}%{_bindir} As %{_bindir} eq /usr/bin, it already has it. 4. Hope you can add a %build section and write: %build # Nothing to build. 5. We have standard of Source0 URL, you can find a direct link when counting 5 in the download page: http://downloads.sourceforge.net/project/kpcli/kpcli-2.3.pl?r=http%3A%2F%2Fsourceforge.net%2Fprojects%2Fkpcli%2Ffiles%2F%3Fsource%3Dnavbar&ts=1377742463&use_mirror=superb-dca2 So it should be: http://downloads.sourceforge.net/project/%{name}/%{name}-%{version}.pl 6. Keep your spec beautiful by reordering: Name: kpcli Version: 2.3 Release: 1%{?dist} Summary: KeePass Command Line Interface (CLI) / interactive shell License: (GPL+ or Artistic) and (GPLv2+ or Artistic) and MIT and Public Domain and UCD BuildArch: noarch URL: http://kpcli.sourceforge.net/ Source0: http://downloads.sourceforge.net/project/%{name}/%{name}-%{version}.pl -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=hqJaLC7cHE&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review