Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: maven2-2.0.4-10jpp.3 - Java project management and project comprehension tool https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=232719 ------- Additional Comments From dbhole@xxxxxxxxxx 2007-03-19 15:57 EST ------- (In reply to comment #7) > It would be nice to have actual instructions for how to recreate these tars, but > I guess since the files are autogenerated on the servers (and have since > changed) and its only for bootstrapping, I guess it should be ok. > True. It wouldn't be possible to write exact generation commands, as the files are probably long gone. > > Added this to the base package > Please also add the appropriate license files for the plugin packages. For > example the following plugins also have license files: > maven-dependency-plugin > maven-repository-plugin > maven-project-info-reports-plugin > Added it for dependency and repository plugins. The one in project-info-reports is in a test directory, and may change in future to something else that is not applicable to the project. > Please see note above about licenses for plugins > > A skipped suggestion: > * consider using cp -p to preserve timestamps > X the -p is not used anywhere in %prep section > Hmm. At first I figured that -p only needs to be in the %install. But I just realized that it should be in all sections, because otherwise, even if %install uses it for that file, the timestamp will be that of the time the cp was done in %prep. I have added -p in all places now. http://people.redhat.com/dbhole/fedora/maven2/maven2.spec http://people.redhat.com/dbhole/fedora/maven2/maven2-2.0.4-10jpp.3.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review