Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: at76_usb-firmware - Firmware for Atmel AT76C503A based USB WLAN adapters https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=221677 ------- Additional Comments From notting@xxxxxxxxxx 2007-03-19 15:53 EST ------- Review: MUST - Package content is acceptable - *** Waiting on driver acceptance. Aside from that, OK. MUST - Package name follows guidelines - OK MUST - Spec file name is %{name}.spec - OK MUST - Package follows Packaging Guidelines - *** Description: 'another' isn't really right. %install - see notes under 'rpmlint output' section below. Source: Please use a full URL to the berlios download URL. MUST - BuildRoot is OK - OK MUST - License is OK - OK MUST - License is properly tagged - *** Per firmware packaging guidelines, should be: License: Redistributable, no modification permitted MUST - License is included in package - OK MUST - Spec is in english, and legible - OK MUST - Sources match upstream - OK MUST - Package builds - OK MUST - Package has proper arch settings - OK MUST - Package has proper BuildRequires - OK MUST - Package handles locales properly - N/A MUST - Package has proper %post scriplets for ldconfig - N/A MUST - Package owns proper directories - N/A MUST - Does not own directories it shouldn't - OK MUST - Package is relocatable if necessary - N/A MUST - Package has no duplicate files - N/A MUST - Package has proper file permissions - N/A MUST - Package has %clean - OK MUST - Package uses macros consistently - OK MUST - Package uses -doc, if needed - N/A MUST - Headers in -devel, if needed - N/A MUST - Static libs in -static - N/A MUST - Uses pkgconfig correctly - N/A MUST - Packages .so correctly - N/A MUST - Subpackages have proper Requires: - N/A MUST - Handles libtool correctly - N/A MUST - Uses .desktop, if necessary - N/A SHOULD - Package includes license as file - OK SHOULD - Builds in mock - OK SHOULD - Package functions - Can't test (no hardware) SHOULD - Scriptlets are sane - N/A SHOULD - File dependencies are sane - N/A rpmlint output: Source: E: at76_usb-firmware hardcoded-library-path in /lib/firmware/${i}.at76_usb E: at76_usb-firmware hardcoded-library-path in $RPM_BUILD_ROOT/lib/firmware E: at76_usb-firmware hardcoded-library-path in $RPM_BUILD_ROOT/lib/firmware E: at76_usb-firmware hardcoded-library-path in $RPM_BUILD_ROOT/lib/firmware E: at76_usb-firmware hardcoded-library-path in /lib/firmware/* OK for firmware. W: at76_usb-firmware macro-in-%changelog doc Please fix, use %%doc in %changelog. E: at76_usb-firmware no-cleaning-of-buildroot %install You need 'rm -rf $RPM_BUILD_ROOT' at the start of %install. Binary: W: at76_usb-firmware symlink-should-be-relative /usr/share/doc/at76_usb-firmware-0.1/README /lib/firmware/README.at76_usb W: at76_usb-firmware symlink-should-be-relative /usr/share/doc/at76_usb-firmware-0.1/COPYRIGHT /lib/firmware/COPYRIGHT.at76_usb This is OK. Please correct the above, and it should then be OK, pending driver acceptance. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review