https://bugzilla.redhat.com/show_bug.cgi?id=896193 --- Comment #16 from Christopher Meng <cickumqt@xxxxxxxxx> --- 1. Source0 Invalid now: Actually URL is: https://launchpad.net/plank/1.0/0.3.0/+download/plank-0.3.0.tar.xz So you need to modify it to: https://launchpad.net/%{name}/1.0/%{version}/+download/%{name}-%{version}.tar.xz 2. log: checking for BAMF... no checking for GEE_0_8... no checking for DBUSMENU... yes So you've missed bamf as BR. ====================== plank 0.3.0 Prefix......................: /usr Vala Compiler...............: /usr/bin/valac Vala Flags..................: --target-glib=2.32 --define HAVE_DBUSMENU C Compiler Flags............: -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector-strong --param=ssp-buffer-size=4 -grecord-gcc-switches -m32 -march=i686 -mtune=atom -fasynchronous-unwind-tables Use gee-0.8.................: no Dbusmenu support............: yes Headless Tests..............: no Documentation...............: no -: This package requires valadoc, I've packaged it but still need upstream to change something, so I block this bug. But for the headless tests, I think you should enable them. 3. devel package need %{?_isa} tag. 4. %{configure} should be: %configure 5. %doc COPYING is not enough: %doc AUTHORS ChangeLog COPYING 6. Don't leave too many blank lines, for example, %package devel Summary: Development files for %{name} Group: Development/Libraries Requires: %{name} = %{version}-%{release} Requires: vala-tools should be %package devel Summary: Development files for %{name} Group: Development/Libraries Requires: %{name} = %{version}-%{release} Requires: vala-tools and the description is not good, change it to something like: The %{name}-devel package contains libraries and header files for developing applications that use %{name}. 7. This package use hidden build, so you can't know the flags/status when building it. Please append V=1 to make %{?_smp_mflags} like this: make %{?_smp_mflags} V=1 to make sure build is not hidden. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=8WlXYQDiP9&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review