https://bugzilla.redhat.com/show_bug.cgi?id=915916 Lubomir Rintel <lkundrak@xxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |lkundrak@xxxxx Assignee|nobody@xxxxxxxxxxxxxxxxx |lkundrak@xxxxx Flags| |fedora-review? --- Comment #2 from Lubomir Rintel <lkundrak@xxxxx> --- * Package named properly - Latest version not used, probably fine - License text is not present - The SPEC file in SRPM and one linked to differ (see below) - SPEC file clean and legible * Require list sane * Provides sane * Filelist sane * Owns all files it should own * Builds fine in mock 0.) You refer to license files in a comment, but don't ship any documentation Please clarify which package are license files in, and possibly ask upstream to include full license text. 1.) Please make sure the package uses correct Source tag, your two SPEC files differ: -Source0: http://download.qt-project.org/archive/qt/5.0/%{version}/submodules/%{qt_module}-opensource-src-%{version}.tar.xz +Source0: http://releases.qt-project.org/qt5/%{version}%{?pre:-%{pre}}/submodules/%{qt_module}-opensource-src-%{version}.tar.xz 3.) Please consider using more useful description than just summary -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=09kRP2N8ao&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review