https://bugzilla.redhat.com/show_bug.cgi?id=929254 --- Comment #4 from Petr Pisar <ppisar@xxxxxxxxxx> --- URL and Source0 are usable. Ok. Source tar ball is original (SHA-256: 2db8c97914025349bf9bb31deae0131dec53d895a5bf00f10c72a4ba75996e71). Ok. Summary verified from lib/Module/CPANfile.pm. Ok. Description verified from lib/Module/CPANfile.pm. Ok. License verified from LICENSE. Ok. No XS code, noarch BuildArch is Ok. TODO: You can use plain `perl' instead of macro `%{__perl}'. TODO: You can remove deleting empty directories in the %install section. These are not created anymore. TODO: Do not package cpanfile, dist.ini. They do not contain any data relevant to an user. META.json is questionable. It lists all contributors and git repository link. TODO: Constrain `perl(ExtUtils::MakeMaker)' build-dependency with `>= 6.30' (Makefile.PL:7). TODO: Build-require `perl(strict)' (Makefile.PL:2). TODO: Build-require `perl(warnings)' (Makefile.PL:3). FIX: Build-require `perl(Data::Dumper)' (lib/Module/CPANfile.pm:115). TODO: Build-require `perl(base)' (t/Utils.pm:2). FIX: Do not build-require `perl(Pod::Usage)'. It's not needed at build-time. Test::Pod is not used. Ok. > Not sure about these BR. Is it needed to mention all of them? > BuildRequires: perl(CPAN::Meta) >= 2.12091 > BuildRequires: perl(CPAN::Meta::Prereqs) >= 2.12091 > BuildRequires: perl(CPAN::Meta::Feature) >= 2.12091 > All of them are need while running tests (lib/Module/CPANfile.pm:100, lib/Module/CPANfile.pm:74, lib/Module/CPANfile.pm:63). All tests pass. Ok. $ rpmlint perl-Module-CPANfile.spec ../SRPMS/perl-Module-CPANfile-1.0001-1.fc21.src.rpm ../RPMS/noarch/perl-Module-CPANfile-1.0001-1.fc21.noarch.rpm 2 packages and 1 specfiles checked; 0 errors, 0 warnings. rpmlint is Ok. $ rpm -q -lv -p ../RPMS/noarch/perl-Module-CPANfile-1.0001-1.fc21.noarch.rpm -rwxr-xr-x 1 root root 2858 Aug 27 13:43 /usr/bin/mymeta-cpanfile drwxr-xr-x 2 root root 0 Aug 27 13:43 /usr/share/doc/perl-Module-CPANfile -rw-r--r-- 1 root root 3223 Aug 5 23:24 /usr/share/doc/perl-Module-CPANfile/Changes -rw-r--r-- 1 root root 18365 Aug 5 23:24 /usr/share/doc/perl-Module-CPANfile/LICENSE -rw-r--r-- 1 root root 1771 Aug 5 23:24 /usr/share/doc/perl-Module-CPANfile/META.json -rw-r--r-- 1 root root 3717 Aug 5 23:24 /usr/share/doc/perl-Module-CPANfile/README -rw-r--r-- 1 root root 153 Aug 5 23:24 /usr/share/doc/perl-Module-CPANfile/cpanfile -rw-r--r-- 1 root root 55 Aug 5 23:24 /usr/share/doc/perl-Module-CPANfile/dist.ini -rw-r--r-- 1 root root 2523 Aug 27 13:43 /usr/share/man/man1/mymeta-cpanfile.1.gz -rw-r--r-- 1 root root 3123 Aug 27 13:43 /usr/share/man/man3/Module::CPANfile.3pm.gz -rw-r--r-- 1 root root 3745 Aug 27 13:43 /usr/share/man/man3/cpanfile-faq.3pm.gz -rw-r--r-- 1 root root 3209 Aug 27 13:43 /usr/share/man/man3/cpanfile.3pm.gz drwxr-xr-x 2 root root 0 Aug 27 13:43 /usr/share/perl5/vendor_perl/Module drwxr-xr-x 2 root root 0 Aug 27 13:43 /usr/share/perl5/vendor_perl/Module/CPANfile -rw-r--r-- 1 root root 7487 Aug 5 23:24 /usr/share/perl5/vendor_perl/Module/CPANfile.pm -rw-r--r-- 1 root root 1057 Aug 5 23:24 /usr/share/perl5/vendor_perl/Module/CPANfile/Environment.pm -rw-r--r-- 1 root root 2248 Aug 5 23:24 /usr/share/perl5/vendor_perl/Module/CPANfile/Result.pm -rw-r--r-- 1 root root 4363 Aug 5 23:24 /usr/share/perl5/vendor_perl/cpanfile-faq.pod -rw-r--r-- 1 root root 3219 Aug 5 23:24 /usr/share/perl5/vendor_perl/cpanfile.pod File layout and permissions are Ok. $ rpm -q --requires -p ../RPMS/noarch/perl-Module-CPANfile-1.0001-1.fc21.noarch.rpm | sort | uniq -c 1 /usr/bin/perl 1 perl(:MODULE_COMPAT_5.18.1) 1 perl(CPAN::Meta) 1 perl(CPAN::Meta::Prereqs) >= 2.12091 1 perl(Carp) 1 perl(Cwd) 1 perl(Getopt::Long) 1 perl(Module::CPANfile) 1 perl(Module::CPANfile::Environment) 1 perl(Module::CPANfile::Result) 1 perl(strict) 1 perl(warnings) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 FIX: Constrain `perl(CPAN::Meta)' run-dependency with `>= 2.12091'. FIX: Run-require `perl(CPAN::Meta::Feature) >= 2.12091' (lib/Module/CPANfile.pm:63). FIX: Run-require `perl(Data::Dumper)' (lib/Module/CPANfile.pm:115). FIX: Run-require `perl(Pod::Usage)' (script/mymeta-cpanfile:20). $ rpm -q --provides -p ../RPMS/noarch/perl-Module-CPANfile-1.0001-1.fc21.noarch.rpm | sort | uniq -c 1 perl(Module::CPANfile) = 1.0001 1 perl(Module::CPANfile::Environment) 1 perl(Module::CPANfile::Result) 1 perl-Module-CPANfile = 1.0001-1.fc21 Binary provides are Ok. $ resolvedeps rawhide ../RPMS/noarch/perl-Module-CPANfile-1.0001-1.fc21.noarch.rpm Binary dependencies resolvable. Ok. Package builds in F21 (http://koji.fedoraproject.org/koji/taskinfo?taskID=5859385). Ok. Otherwise the package is in line with Fedora and Perl packaging guidelines. Please correct all `FIX' issues, consider fixing `TODO' items, and provide new spec file. Resolution: Package NOT approved. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Rpt3u4DIoQ&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review