https://bugzilla.redhat.com/show_bug.cgi?id=912960 Mamoru TASAKA <mtasaka@xxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |package-review@lists.fedora | |project.org --- Comment #11 from Mamoru TASAKA <mtasaka@xxxxxxxxxxxxxxxxx> --- (In reply to Miroslav Suchý from comment #9) > Current header files are not arch-dependent. So lets stick to it. We (or > you) will address it when (and if) they become arch dependent. Which is BTW > discouraged. Then leave this as it is. Touching every 13 (and more) packages (again not only for rubygem-gdk3) to add -I/usr/share/.... is very annoying. Also, putting header file under "/usr/share" is _much_ discouraged than to put it inder /usr/lib (while putting header file under /usr/lib can be seen by other packages, putting header file under /usr/share is - as far as I know - no package puts them. (In reply to Vít Ondruch from comment #10) > (In reply to Miroslav Suchý from comment #7) > > >- Well, this is wrapper for gdk, and actually (if test fails) > > > debugging it sometimes takes really much times. Sometimes > > > even upstream can't fix this in a short time. So unless there > > > is apparently critical issue to fix, I want to just notice upstream > > > about test failure (if any). > > > > Sounds reasonable. But only if the test is currently failing. I would like > > to the there: > > ruby -Ilib:test ./test/run-test.rb > > and if test will start fail, you can then *temporary* add > > ... || echo "Know problem BZ XXX" > > This way users (e.g provepackagers) will know why the failing test is waived > > and can checkout the progress. You may want to add some comment for > > provenpackagers, that if test is failing, you can temporary disable it this > > way and report the problem at XXX. > > Do you agree? > > I prefer to grep for specific results, e.g. | grep "216 tests, 325 > assertions, 0 failures, 16 errors, 0 skips". That ensures, that the test > results are constant and we know about changes. The || echo or || : is too > vague for my taste. Well, actually I was going to propose to _not_ using grep. Using grep, actually what tests failed cannot be seen on build.log (only the result of grep appears), which makes build.log less useful then other people tries to look at it. (BTW, it is preferable to check build.log even if build is successful) > > Not mentioning that in this specific case, there is not executed even single > test, since it blows apart right from the start :/ -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=vGmtb0b5tM&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review