https://bugzilla.redhat.com/show_bug.cgi?id=989775 --- Comment #1 from Lubomir Rintel <lkundrak@xxxxx> --- * The package is properly named * Versioning is sane * License is fine * SPEC file is clean and legible * RPMlint is happy * Builds fine in mock * Source file matches upstream * Requires sane * Provides sane * Filelist sane 1.) No need to explicitely set noarch here %package doc ... BuildArch: noarch 2.) It's probably not a good idea to modify the files in build tree from check. %prep is better suited for this purpose: %check pushd .%{gem_instdir} # Remove unneeded coveralls sed -i '/[Cc]overalls/d' spec/helper.rb 3.) Keeping README in -doc subpackage is a bad idea ...despite what some Ruby packagers unaware of RPM transaction flags think :( Please move it into the main package. User should not need to install a subpackage to learn important information about the main package. %files doc ... %doc %{gem_instdir}/README.md -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=DCsS9Hkz9X&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review