[Bug 1000731] Review Request: waffle - Platform independent GL API layer

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1000731



--- Comment #3 from Christopher Meng <cickumqt@xxxxxxxxx> ---
- You bump the release in SPEC on fp.o, but not the SRPM.

- Requires:   %{name} = %{version}-%{release}

Due to
https://fedoraproject.org/wiki/Packaging:Guidelines#BuildRequires_and_.25.7B_isa.7D

should be:

Requires:   %{name}%{?_isa} = %{version}-%{release}

- Are these examples belonged to Group:      Development/Libraries?

- CMAKE Options:

option(waffle_build_tests "Build tests" ON)
option(waffle_build_manpages "Build manpages" OFF)
option(waffle_build_htmldoc "Build html documentation" OFF)
option(waffle_build_examples "Build examples" ON)
option(waffle_has_glx "Build support for GLX" OFF)
option(waffle_has_wayland "Build support for Wayland" OFF)
option(waffle_has_x11_egl "Build support for X11/EGL" OFF)
option(waffle_has_gbm "Build support for GBM" OFF)

You just define -Dwaffle_has_glx=1, why not enable others such as wayland?

================================

Rpmlint (installed packages)
----------------------------
# rpmlint waffle-examples waffle-devel waffle
waffle-devel.i686: E: arch-dependent-file-in-usr-share
/usr/share/doc/waffle-devel/examples/gl_basic
waffle-devel.i686: W: unstripped-binary-or-object
/usr/share/doc/waffle-devel/examples/gl_basic
waffle-devel.i686: E: binary-or-shlib-defines-rpath
/usr/share/doc/waffle-devel/examples/gl_basic
['/builddir/build/BUILD/waffle-1.2.3/lib']
waffle-devel.i686: E: arch-dependent-file-in-usr-share
/usr/share/doc/waffle-devel/examples/simple-x11-egl
waffle-devel.i686: W: unstripped-binary-or-object
/usr/share/doc/waffle-devel/examples/simple-x11-egl
waffle-devel.i686: E: binary-or-shlib-defines-rpath
/usr/share/doc/waffle-devel/examples/simple-x11-egl
['/builddir/build/BUILD/waffle-1.2.3/lib']
waffle-devel.i686: E: arch-dependent-file-in-usr-share
/usr/share/doc/waffle-devel/examples/CMakeFiles/simple-x11-egl.dir/simple-x11-egl.c.o
waffle-devel.i686: E: arch-dependent-file-in-usr-share
/usr/share/doc/waffle-devel/examples/CMakeFiles/gl_basic.dir/gl_basic.c.o
waffle-devel.i686: E: non-standard-executable-perm
/usr/share/doc/waffle-devel/examples/gl_basic 0775L
waffle-devel.i686: W: spurious-executable-perm
/usr/share/doc/waffle-devel/examples/gl_basic
waffle-devel.i686: E: non-standard-executable-perm
/usr/share/doc/waffle-devel/examples/simple-x11-egl 0775L
waffle-devel.i686: W: spurious-executable-perm
/usr/share/doc/waffle-devel/examples/simple-x11-egl
waffle-devel.i686: E: version-control-internal-file
/usr/share/doc/waffle-devel/examples/gl_basic.xcodeproj/.gitignore
waffle-devel.i686: W: doc-file-dependency
/usr/share/doc/waffle-devel/examples/gl_basic rtld(GNU_HASH)
waffle-devel.i686: W: doc-file-dependency
/usr/share/doc/waffle-devel/examples/simple-x11-egl rtld(GNU_HASH)
waffle-devel.i686: W: doc-file-dependency
/usr/share/doc/waffle-devel/examples/gl_basic libc.so.6(GLIBC_2.7)
waffle-devel.i686: W: doc-file-dependency
/usr/share/doc/waffle-devel/examples/gl_basic libX11-xcb.so.1
waffle-devel.i686: W: doc-file-dependency
/usr/share/doc/waffle-devel/examples/simple-x11-egl libX11-xcb.so.1
waffle-devel.i686: W: doc-file-dependency
/usr/share/doc/waffle-devel/examples/gl_basic libpthread.so.0(GLIBC_2.0)
waffle-devel.i686: W: doc-file-dependency
/usr/share/doc/waffle-devel/examples/gl_basic libc.so.6(GLIBC_2.0)
waffle-devel.i686: W: doc-file-dependency
/usr/share/doc/waffle-devel/examples/simple-x11-egl libc.so.6(GLIBC_2.0)
waffle-devel.i686: W: doc-file-dependency
/usr/share/doc/waffle-devel/examples/gl_basic libxcb.so.1
waffle-devel.i686: W: doc-file-dependency
/usr/share/doc/waffle-devel/examples/simple-x11-egl libxcb.so.1
waffle-devel.i686: W: doc-file-dependency
/usr/share/doc/waffle-devel/examples/gl_basic libGL.so.1
waffle-devel.i686: W: doc-file-dependency
/usr/share/doc/waffle-devel/examples/simple-x11-egl libGL.so.1
waffle-devel.i686: W: doc-file-dependency
/usr/share/doc/waffle-devel/examples/gl_basic libpthread.so.0
waffle-devel.i686: W: doc-file-dependency
/usr/share/doc/waffle-devel/examples/simple-x11-egl libpthread.so.0
waffle-devel.i686: W: doc-file-dependency
/usr/share/doc/waffle-devel/examples/gl_basic libc.so.6(GLIBC_2.3.4)
waffle-devel.i686: W: doc-file-dependency
/usr/share/doc/waffle-devel/examples/gl_basic libdl.so.2
waffle-devel.i686: W: doc-file-dependency
/usr/share/doc/waffle-devel/examples/simple-x11-egl libdl.so.2
waffle-devel.i686: W: doc-file-dependency
/usr/share/doc/waffle-devel/examples/gl_basic libX11.so.6
waffle-devel.i686: W: doc-file-dependency
/usr/share/doc/waffle-devel/examples/simple-x11-egl libX11.so.6
waffle-devel.i686: W: doc-file-dependency
/usr/share/doc/waffle-devel/examples/gl_basic libc.so.6
waffle-devel.i686: W: doc-file-dependency
/usr/share/doc/waffle-devel/examples/simple-x11-egl libc.so.6
waffle-devel.i686: W: doc-file-dependency
/usr/share/doc/waffle-devel/examples/gl_basic libc.so.6(GLIBC_2.4)
waffle-devel.i686: W: doc-file-dependency
/usr/share/doc/waffle-devel/examples/simple-x11-egl libc.so.6(GLIBC_2.4)

1. version-control-internal-file error, should be fixed;
2. doc-file-dependency is caused by wrong permissions
%doc(spurious-executable-perm/non-standard-executable-perm), please chmod.
3. arch-dependent-file-in-usr-share error is caused by object files, can you
remove them?
4. Other errors are example files related. Just fix permissions is enough.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=UWWGyq1BcR&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]