https://bugzilla.redhat.com/show_bug.cgi?id=1001396 Bug ID: 1001396 Summary: Review Request: golang-pty - PTY interface for Go Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@xxxxxxxxxxxxxxxxx Reporter: lsm5@xxxxxxxxxx QA Contact: extras-qa@xxxxxxxxxxxxxxxxx CC: notting@xxxxxxxxxx, package-review@xxxxxxxxxxxxxxxxxxxxxxx Similar format as bug 1001300, so comments on that one would probably apply to this package too. Also, I had 1 query regarding the version. Upstream mentions a prior release as r56. I'm not quite sure what release to put here, I just added 0.0.1 (this also goes for bug 1001300 and bug 1001317) Spec URL: http://lsm5.fedorapeople.org/rpmbuild/SPECS/golang-pty.spec SRPM URL: http://lsm5.fedorapeople.org/rpmbuild/SRPMS/golang-pty-0.0.1-1.fc21.src.rpm Description: Pty is a Go package for using unix pseudo-terminals. Fedora Account System Username: lsm5 Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=5857862 $ rpmlint SPECS/golang-pty.spec 0 packages and 1 specfiles checked; 0 errors, 0 warnings. $ rpmlint SRPMS/golang-pty-0.0.1-1.fc21.src.rpm golang-pty.src: W: spelling-error %description -l en_US unix -> UNIX, Unix, uni 1 packages and 0 specfiles checked; 0 errors, 1 warnings. $ rpmlint RPMS/x86_64/golang-pty-0.0.1-1.fc21.x86_64.rpm golang-pty.x86_64: W: spelling-error %description -l en_US unix -> UNIX, Unix, uni golang-pty.x86_64: E: no-binary golang-pty.x86_64: W: only-non-binary-in-usr-lib golang-pty.x86_64: E: script-without-shebang /usr/lib64/golang/src/cmd/pty/run.go golang-pty.x86_64: E: script-without-shebang /usr/lib64/golang/src/cmd/pty/util.go golang-pty.x86_64: E: script-without-shebang /usr/lib64/golang/src/cmd/pty/doc.go golang-pty.x86_64: E: script-without-shebang /usr/lib64/golang/src/cmd/pty/pty_darwin.go golang-pty.x86_64: E: script-without-shebang /usr/lib64/golang/src/cmd/pty/pty_linux.go 1 packages and 0 specfiles checked; 6 errors, 2 warnings. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=H51ruGkWtO&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review