https://bugzilla.redhat.com/show_bug.cgi?id=1000662 --- Comment #2 from Lokesh Mandvekar <lsm5@xxxxxxxxxx> --- (In reply to Matthew Miller from comment #1) > > Name: lxc-docker > > Where does the name come from? This name implies a relation to > http://lxc.sourceforge.net/ -- I know there's *also* libvirt LXC, but I > don't think we want to make the confusion even worse! > > There is an existing "docker" package in Fedora, a desktop dock applet for > Gnome 2 and KDE. That hasn't been changed upstream since 2002, and hasn't > been maintained in fedora except for the initial package and a specfile fix > in 2007. I wonder if maybe we could drop it or rename it? > > I know that package was there first, but I don't know if that's a good > reason to hold on to a name forever. > > (Problems with flat fedora universe in action... *sigh*.) > > Failing that, maybe docker-io or something? (shades of openoffice.org.... > ugh) I did name it docker-io initially. But, I talked on #docker and they said everyone goes with lxc-docker, so it's better fedora goes with it too. That said, lxc will soon be optional (deprecated?) and the whole docker community will decide on a new package name. > > > > Source0: http://lsm5.fedorapeople.org/v%{version}.tar.gz > > We need the upstream source. If you're pulling from github, do it like this: > http://fedoraproject.org/wiki/Packaging:SourceURL#Github > > > BuildRequires: git > > It's not actually checking code out of git at build time is it? The default build process did pull stuff using git, but the recent spec file gets rid of that. Fixed in new spec file: Spec URL: http://lsm5.fedorapeople.org/rpmbuild/SPECS/lxc-docker.spec SRPM URL: http://lsm5.fedorapeople.org/rpmbuild/SRPMS/lxc-docker-0.5.3-2.fc21.src.rpm $ rpmlint SPECS/lxc-docker.spec SPECS/lxc-docker.spec:52: W: rpm-buildroot-usage %build mkdir -p %{buildroot}%{_bindir} SPECS/lxc-docker.spec:53: W: rpm-buildroot-usage %build mkdir -p %{buildroot}%{_mandir}/man1 SPECS/lxc-docker.spec:54: W: rpm-buildroot-usage %build install -p bin/docker %{buildroot}%{_bindir} SPECS/lxc-docker.spec:57: W: rpm-buildroot-usage %build cp -p packaging/debian/*.1.gz %{buildroot}%{_mandir}/man1 SPECS/lxc-docker.spec: W: no-%install-section 0 packages and 1 specfiles checked; 0 errors, 5 warnings. $ rpmlint SRPMS/lxc-docker-0.5.3-2.fc21.src.rpm lxc-docker.src:52: W: rpm-buildroot-usage %build mkdir -p %{buildroot}%{_bindir} lxc-docker.src:53: W: rpm-buildroot-usage %build mkdir -p %{buildroot}%{_mandir}/man1 lxc-docker.src:54: W: rpm-buildroot-usage %build install -p bin/docker %{buildroot}%{_bindir} lxc-docker.src:57: W: rpm-buildroot-usage %build cp -p packaging/debian/*.1.gz %{buildroot}%{_mandir}/man1 lxc-docker.src: W: no-%install-section 1 packages and 0 specfiles checked; 0 errors, 5 warnings. $ rpmlint RPMS/x86_64/lxc-docker-0.5.3-2.fc21.x86_64.rpm lxc-docker.x86_64: W: unstripped-binary-or-object /usr/bin/docker lxc-docker.x86_64: E: statically-linked-binary /usr/bin/docker 1 packages and 0 specfiles checked; 1 errors, 1 warnings. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=T74a1WAjWS&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review