https://bugzilla.redhat.com/show_bug.cgi?id=998459 --- Comment #4 from Miroslav Suchý <msuchy@xxxxxxxxxx> --- > * MRI specfic Requires: Not needed, I was specified in gemspec. And it seems that author just wanted to say ruby higher the 1.8. And since that is valid on all current Fedoras, plain Requires: ruby(release) is enough. > * Virtual (Build)Requires preferred Fixed. > ? Perhaps unneeded commands It works without that as well. Hmm, why I added that? Could not recall. Removing. > * Main documents I moved LICENSE and README. I choosed to keep CHANGELOG in -doc. > * Unwanted documents Those test are not in main package (this is what Guideliness are saying). They are presented in -doc subpackage (which does all other rubygems package as well). This is IMO good as test are in fact often good examples how to use that library. The same for Rakefile. > Please contact the submitter of bug 886871. Aha, did not noticed that. Jstribrny sits in the same cubicle as me, I will tell him as soon as hi appear in office. Closing bug 886871 as duplicate. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=TuDqhvCZgS&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review