[Bug 912960] Review Request: rubygem-gdk3 - Ruby binding of GDK-3.x

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=912960



--- Comment #5 from Miroslav Suchý <msuchy@xxxxxxxxxx> ---
rpmlint:
rubygem-gdk3.x86_64: E: incorrect-fsf-address
/usr/share/gems/gems/gdk3-2.0.2/COPYING.LIB
rubygem-gdk3.src: W: strange-permission gdk3-2.0.2.gem 0600L


> ruby -Ilib:test ./test/run-test.rb || echo "Please investigate this"
Why that ||?
If the test fail, it will not take down whole build. Which is what we generally
want to, isn't it?


I'm really not sure about:
  %global header_dir  %{ruby_vendorarchdir}
this is not in guidelines, so it is just IMHO, but... I think (after
consultation with vondrouch), that header files should go to:
["vendorarchhdrdir", "/usr/include/vendor_ruby/x86_64-linux"]
------------^^^ notice this
or 
$  pkg-config --variable=vendorhdrdir ruby
/usr/include/vendor_ruby
which is unfortunately not provided by any macro (as rubygem-foo-devel is not
usual).
Can you consider moving header files there?

And if you provide -devel package, should you provide even so-name?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=MFUTMz7nJ7&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]