https://bugzilla.redhat.com/show_bug.cgi?id=816565 Hans de Goede <hdegoede@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Flags|needinfo?(hdegoede@redhat.c |fedora-review+ |om) | --- Comment #6 from Hans de Goede <hdegoede@xxxxxxxxxx> --- Cool that it has all free resources now, full review done: Good: -------- - rpmlint checks return: 3 packages and 0 specfiles checked; 0 errors, 0 warnings. - package meets naming guidelines - package meets packaging guidelines - license (GPLv2+ and CC-BY and CC-BY-SA and CC0 and GPLv3) OK, text in %doc, matches source - spec file legible, in am. english - source matches upstream - package compiles on devel (x86) - no missing BR - no unnecessary BR - no locales - not relocatable - owns all directories that it creates - no duplicate files - permissions ok - macro use consistent - code, not content - no need for -docs - nothing in %doc affects runtime - .desktop file properly installed Should fix: --------------- - The rm -rf %{buildroot} at the beginning of %install is obsolete / no longer needed, please remove it No blockers: APPROVED, don't forget to bump the release so that the Fedora package is newer then the rpmfusion one. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=RlGJi7IWX7&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review