Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: eclipse-nlspackager - Eclipse NLS package generator https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=232709 ------- Additional Comments From fitzsim@xxxxxxxxxx 2007-03-19 13:01 EST ------- (In reply to comment #2) > All fixed, execpt > > ? source and patches verified > > - where does the zip file come from? I couldn't find a link to it > from http://wiki.eclipse.org/index.php/Linux_Distributions_Project > > - Since this package does not have any official website yet, so the link to a > Zip file will be added to the wiki soon. Is the zip file already hosted somewhere? > > > Modified files can be found at: > > > Spec URL: http://sourceware.org/eclipse/nls/eclipse-nlspackager.spec > SRPM URL: http://sourceware.org/eclipse/nls/eclipse-nlspackager-0.1.3-1.src.rpm > I still see these problems: - a gcj_support fragment: it should be either removed or filled out to full GCJ support - whitespace problems: at the default tab width of 8 characters, several lines many lines are longer than 80 characters. You should wrap them using '\' at the end of a line. For example: install -p SDK/plugins/org.eclipse.linuxtools.nlspackager_%{version}.jar \ $RPM_BUILD_ROOT%{eclipse_base}/plugins/ emacs's untabify mode may help you here. The summary still has a trailing space. - the description could be clearer New problems: - you can tag documentation files relative to the build root. So you %doc lines should be one shorter line: %doc LICENSE ChangeLog Then you can remove this install line: install -p -m 644 nlspackager/ChangeLog nlspackager/LICENSE $RPM_BUILD_ROOT%{eclipse_base}/features/org.eclipse.linuxtools.nlspackager_%{version} and rpm will do the right thing. - changelog entries are separated by spaces -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review