https://bugzilla.redhat.com/show_bug.cgi?id=1000078 Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |zbyszek@xxxxxxxxx --- Comment #2 from Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> --- Can't sponsor you, but I can review the package: Hm, actually looking at the scripts, I'm pretty sure that they shouldn't be packaged for Fedora, at least as is. They might work for simple cases, but those scripts are quite brute force: dmc-load will be run when any block device is inserted, so e.g. inserting a USB stick might cause actions to be performed. I'm not sure what is the proper way to do this, but it certainly doesn't seem right. Probably the example of LVM should be followed, to perform setup only for the device that was just plugged in. In case you want to continue packaging in some form: Source: please define global %gitcommit and use https://github.com/opinsys/dmcache-utils/archive/%{gitcommit}.tar.gz. Then %setup can use -n %{name}-%{gitcommit}. %description should say what the scripts actually do ("simplify the usage" is too generic). License should be GPLv2+, not GPLv2. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=A3hYdibbh3&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review