https://bugzilla.redhat.com/show_bug.cgi?id=998410 Jitka Plesnikova <jplesnik@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|package-review@lists.fedora | |project.org | Status|NEW |ASSIGNED CC| |jplesnik@xxxxxxxxxx Assignee|nobody@xxxxxxxxxxxxxxxxx |jplesnik@xxxxxxxxxx Flags| |fedora-review+ --- Comment #1 from Jitka Plesnikova <jplesnik@xxxxxxxxxx> --- Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. [-]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [x]: Package does not own files or directories owned by other packages. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [!]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Sources contain only permissible code or content. [x]: Macros in Summary, %description expandable at SRPM build time. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [-]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Each %files section contains %defattr if rpm < 4.4 [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Perl: [x]: Package contains the mandatory BuildRequires and Requires:. [x]: CPAN urls should be non-versioned. ===== SHOULD items ===== Generic: [!]: Buildroot is not present Note: Invalid buildroot found: %{_tmppath}/%{name}-%{version}-%{release}-root-%(id -nu) See: http://fedoraproject.org/wiki/Packaging/Guidelines#BuildRoot_tag [!]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) Note: %clean present but not required [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Dist tag is present (not strictly required in GL). [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: SourceX tarball generation or download is documented. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. $ rpmlint ./perl-Carp-Fix-1_25.spec ./perl-Carp-Fix-1_25-1.000001-2.fc21.* perl-Carp-Fix-1_25.noarch: W: unexpanded-macro %description -l C %Carp perl-Carp-Fix-1_25.noarch: W: spelling-error %description -l en_US namespace -> name space, name-space, names pace perl-Carp-Fix-1_25.src: W: unexpanded-macro %description -l C %Carp perl-Carp-Fix-1_25.src: W: spelling-error %description -l en_US namespace -> name space, name-space, names pace 2 packages and 1 specfiles checked; 0 errors, 4 warnings. Rpmlint ok. $ rpm -qp --provides ../../results/perl-Carp-Fix-1_25-1.000001-2.fc21.noarch.rpm | sort | uniq -c 1 perl(Carp::Fix::1_25) = 1.000001 1 perl(Carp::Fix::1_25::Fixed) 1 perl-Carp-Fix-1_25 = 1.000001-2.fc21 Binary provides ok. $ rpm -qp --requires ../../results/perl-Carp-Fix-1_25-1.000001-2.fc21.noarch.rpm | sort | uniq -c 1 perl >= 0:5.008 1 perl(:MODULE_COMPAT_5.18.1) 1 perl(Carp) 1 perl(Exporter) 1 perl(strict) 1 perl(warnings) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 Binary requires ok. Source checksums ---------------- http://cpan.metacpan.org/authors/id/M/MS/MSCHWERN/Carp-Fix-1_25-1.000001.tar.gz : CHECKSUM(SHA256) this package : 241ebd75dbbd6564a0430a9c413caf9805ea27e94bce5034fb85b33b5e26984a CHECKSUM(SHA256) upstream package : 241ebd75dbbd6564a0430a9c413caf9805ea27e94bce5034fb85b33b5e26984a ISSUE: * Remove BuildRoot tag. * Drop removing of buildroot. It is not needed now. * Remove %clean section. However, these are needed for EPEL 5 support. * perl(Test::More) is bundled and also listed at BR. To be sure that system library is used, please remove the content of t/lib and update MANIFEST. Otherwise, package is good. APPROVED -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=9tKHR5Px5U&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review