Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: dkms - Dynamic Kernel Module Support https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=221084 ------- Additional Comments From mebrown@xxxxxxxxxxxxxxxxxx 2007-03-19 12:13 EST ------- http://fedoraproject.org/wiki/Packaging/NamingGuidelines * name matches upstream tarball. No illegal delimiters. * no multiple packages with same base name * spec file named correctly * versioned properly. * %{dist} tag properly used * no doc subpackage * is not an addon package http://fedoraproject.org/wiki/Packaging/Guidelines * license is GPL * no patents * no emulators * no binary firmware * no pre-built binaries. * good changelog * no 'copyright', 'packager' or 'vendor' tags * summary tag does not end in dot * no prereq * Source: tag documents where to find upstream. * good buildroot tag * no file deps * no build deps (it is a shell script) * american english * utf8 spec file * relevant docs included * no compiled code (compiler flags irrelevant) * no debuginfo since no compiled code. * no libraries (static or otherwise) * no rpath issues * config files properly (noreplace) * init script isnt marked %{config} * no .desktop files (not a GUI app) * consistent variable usage. * no %makeinstall macro usage * no locale files * scriptlets dont modify dirs they shouldnt * no conditional dependencies (--with/--without) * not relocatable * no content * owns its dirs * not a webapp -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review