https://bugzilla.redhat.com/show_bug.cgi?id=998434 --- Comment #3 from Paul Howarth <paul@xxxxxxxxxxxx> --- (In reply to Jitka Plesnikova from comment #1) > Issues: > TODO: Remove BuildRoot tag. > TODO: Drop removing of buildroot. It is not needed now. > TODO: Remove %clean section. > > Please consider fixing 'TODO' items. These are needed for EL-5 support. > Otherwise package looks good. > APPROVED Thanks for the review again Jitka. (In reply to Christopher Meng from comment #2) > It's not 'consider', it's MUST Yes, it's a MUST for EL-5 support: https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/Guidelines#.25clean The %clean section is not required for F-13 and above. Each package for F-12 and below (or EPEL 5) MUST have a %clean section, which contains rm -rf %{buildroot} (or $RPM_BUILD_ROOT). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=eLWc3W6fj9&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review