https://bugzilla.redhat.com/show_bug.cgi?id=949317 --- Comment #5 from Vít Ondruch <vondruch@xxxxxxxxxx> --- * Separate changelog entries by empty line - It is common - It is easier to read - Some tools cannot handle the changelog properly. Try "$ fedpkg clog" for example. * Remove BuildRoot - This tag is not needed for Fedora. It is useful just for EPEL5. * Remove %defattr - This is now default. No need to specify. Please remove the macro. * Exclude %{gem_cache} - Please %exclude %{gem_cache}. This file has no purpose on Fedora. * Please execute test suite if possible. * Backslash in %description is not needed IMO. * %{gem_instdir} ownership - I typically suggest to structure %files section as follows %dir %{gem_instdir} %{gem_libdir} - You own directly the %{gem_instdir}, but that means you own whole content of that directory. It means that during further updates, there might slip through your hands important additions etc. This is not a show stopper, but good practice IMO. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Tyq3srsp12&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review