https://bugzilla.redhat.com/show_bug.cgi?id=999690 Joshua Small <technion@xxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|package-review@lists.fedora | |project.org | CC| |technion@xxxxxxxxxxx --- Comment #1 from Joshua Small <technion@xxxxxxxxxxx> --- Hi, I'd like to offer some review comments. The obvious one here, is that I'm guessing you're seeking a preapproval of sorts - the major issue would be that a re-review would be required once a stable tag is packaged. In the meantime, rpmlint produces a few things to look at: bcache-tools.x86_64: W: incoherent-version-in-changelog 20130820 ['0.0-1.20130820git.fc19', '0.0-1.20130820git'] I'm expecting a "1.0" release tag in future would resolve this, otherwise, please see the naming guidelines: http://fedoraproject.org/wiki/Packaging:NamingGuidelines#Package_Versioning bcache-tools.x86_64: W: only-non-binary-in-usr-lib There are only non binary files in /usr/lib so they should be in /usr/share. False positive? bcache-tools.x86_64: W: no-manual-page-for-binary bcache-register Each executable in standard binary directories should have a man page. There are man pages for each executable but this one. Other points: Please use the -p flag on installation to preserve the timestamp as per: http://fedoraproject.org/wiki/Packaging:Guidelines#Timestamps The buildroot tag is obsolete and should be removed: http://fedoraproject.org/wiki/Packaging:Guidelines#BuildRoot_tag Consider using %global over %define: http://fedoraproject.org/wiki/Packaging:Guidelines#.25global_preferred_over_.25define The %clean is obsolete: http://fedoraproject.org/wiki/Packaging:Guidelines#.25clean Hopefully this helps you towards a cleaner spec file for your stable revision. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=u8m0ClhraC&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review