https://bugzilla.redhat.com/show_bug.cgi?id=998701 Matthew Farrellee <matt@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEW Summary|Review Request: |Review Request: |python-savannaclient - |python-savannaclient - |Python API for OpenStack |Client library for |Savanna |OpenStack Savanna API --- Comment #3 from Matthew Farrellee <matt@xxxxxxxxxx> --- - Fix version in changelog (release is -0.1* not -0.3*) -> DONE - README.rst is empty - don't include it in %doc -> DONE - requirements.txt states babel and netaddr and these are imported at openstack/common/{jsonutils,gettextutils}.py but they aren't listed as Requires. Not sure if they are used/needed, please check. -> DONE: added Requires: python-babel and python-netaddr - [OPTIONAL] You might consider nuking hard capped setup_requires from setup.py to avoid problems in future (like pbr downloading them during build when versions aren't met). -> NOT DONE: previously I tried to do that w/ sed -i '/.../d' and was not successful, suggestions? - [OPTIONAL] I presume you took Description/Summary from novaclient which IMHO kinda sucks. I present arguably clearer alternatives, although it's really a matter of taste so feel free to ignore me here: - Summary: Client library for OpenStack Savanna API - Description: Python client library for interacting with OpenStack Savanna API. -> DONE: I like your suggestions Also, changed "%{shortcommit}" to "%%{..." per rpmlint's "python-savannaclient.src:12: W: macro-in-comment %{shortcommit}". Spec URL: http://matt.fedorapeople.org/pkg/1/python-savannaclient.spec SRPM URL: http://matt.fedorapeople.org/pkg/1/python-savannaclient-0.3-0.1.f816386git.fc19.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=3pI63wqmfg&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review