[Bug 998738] Review Request: python-yapsy - A simple plugin system for Python applications

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=998738

Christopher Meng <cickumqt@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|package-review@lists.fedora |
                   |project.org                 |



--- Comment #1 from Christopher Meng <cickumqt@xxxxxxxxx> ---
Invalid:

1. Release:    1 ---> Missing dist macro

2. License:    BSD, CC-BY-SA ---> Please follow the licensing guideline and
fix, but DO NOT use any comma.

3. BuildRequires:     python --->BuildRequires:     python2-devel

Also remove the trailing space.

4. Where?


%package -n python3-yapsy-doc
Summary:    Documentation for python2-yapsy, a plugin system for Python3
applications.
Group:        Development/Libraries
%description -n python3-yapsy-doc
Documentation for yapsy, a simple plugin system for python3 applications.
%endif

I strongly recommend you generate one NOARCH doc subpackage for py2.7 and py3.x

5. What??!!

%files
%dir %{python_sitelib}/%{projectname}-%{version}_pythons2n3-py2.7.egg-info/
%{python_sitelib}/%{projectname}-%{version}_pythons2n3-py2.7.egg-info/PKG-INFO
%{python_sitelib}/%{projectname}-%{version}_pythons2n3-py2.7.egg-info/SOURCES.txt
%{python_sitelib}/%{projectname}-%{version}_pythons2n3-py2.7.egg-info/dependency_links.txt
%{python_sitelib}/%{projectname}-%{version}_pythons2n3-py2.7.egg-info/top_level.txt
%dir %{python_sitelib}/%{productname}/
%{python_sitelib}/%{productname}/AutoInstallPluginManager.py
%{python_sitelib}/%{productname}/AutoInstallPluginManager.pyc
%{python_sitelib}/%{productname}/AutoInstallPluginManager.pyo
%{python_sitelib}/%{productname}/ConfigurablePluginManager.py
%{python_sitelib}/%{productname}/ConfigurablePluginManager.pyc
%{python_sitelib}/%{productname}/ConfigurablePluginManager.pyo
%{python_sitelib}/%{productname}/FilteredPluginManager.py
%{python_sitelib}/%{productname}/FilteredPluginManager.pyc
%{python_sitelib}/%{productname}/FilteredPluginManager.pyo
%{python_sitelib}/%{productname}/IPlugin.py
%{python_sitelib}/%{productname}/IPlugin.pyc
%{python_sitelib}/%{productname}/IPlugin.pyo
%{python_sitelib}/%{productname}/IPluginLocator.py
%{python_sitelib}/%{productname}/IPluginLocator.pyc
%{python_sitelib}/%{productname}/IPluginLocator.pyo
%{python_sitelib}/%{productname}/PluginFileLocator.py
%{python_sitelib}/%{productname}/PluginFileLocator.pyc
%{python_sitelib}/%{productname}/PluginFileLocator.pyo
%{python_sitelib}/%{productname}/PluginInfo.py
%{python_sitelib}/%{productname}/PluginInfo.pyc
%{python_sitelib}/%{productname}/PluginInfo.pyo
%{python_sitelib}/%{productname}/PluginManager.py
%{python_sitelib}/%{productname}/PluginManager.pyc
%{python_sitelib}/%{productname}/PluginManager.pyo
%{python_sitelib}/%{productname}/PluginManagerDecorator.py
%{python_sitelib}/%{productname}/PluginManagerDecorator.pyc
%{python_sitelib}/%{productname}/PluginManagerDecorator.pyo
%{python_sitelib}/%{productname}/VersionedPluginManager.py
%{python_sitelib}/%{productname}/VersionedPluginManager.pyc
%{python_sitelib}/%{productname}/VersionedPluginManager.pyo
%{python_sitelib}/%{productname}/__init__.py
%{python_sitelib}/%{productname}/__init__.pyc
%{python_sitelib}/%{productname}/__init__.pyo

is ugly, change to:

%{python_sitelib}/%{projectname}-%{version}_pythons2n3-py%{python_version}.egg-info
%{python_sitelib}/%{productname}

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=UxuyaZ5z1F&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]