https://bugzilla.redhat.com/show_bug.cgi?id=997990 Kalev Lember <kalevlember@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |kalevlember@xxxxxxxxx Assignee|nobody@xxxxxxxxxxxxxxxxx |kalevlember@xxxxxxxxx --- Comment #1 from Kalev Lember <kalevlember@xxxxxxxxx> --- Taking for review. Can you update to the new 4.10.3 release that has the patches? > BuildRequires: vala-devel > BuildRequires: libxfce4util-devel > BuildRequires: garcon-devel > BuildRequires: xfconf-devel > BuildRequires: libxfce4ui-devel > BuildRequires: xfce4-panel-devel > BuildRequires: exo-devel > BuildRequires: xfce4-dev-tools Minor nitpick: these would look nicer sorted. > Requires: pkgconfig rpmbuild autogenerates the pkgconfig dep for all packages that ship a .pc file; no need to do it manually. > %configure --with-vala-api=0.20 I'm building vala 0.21 for rawhide right now, can you update this to pass API version 0.22 ? > %{_datadir}/vala-0.20/vapi/* Should depend on the vala package for the /usr/share/vala-*/ directory ownership. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=PwqCSIltAV&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review