Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: unpaper - Post-processing of scanned and photocopied book pages https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=232406 wolfy@xxxxxxxxxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@xxxxxxxxxxxxxxxxx |wolfy@xxxxxxxxxxxxxxxxxx Flag| |fedora-review+ ------- Additional Comments From wolfy@xxxxxxxxxxxxxxxxxx 2007-03-19 05:08 EST ------- GOOD - rpmlint does not return anything, either on source or on binary rpm - package meets naming guidelines - package meets packaging guidelines - license ( GPL) OK, text in %doc, matches source - spec file legible, in am. english - source matches upstream, is latest version, sha1sum is c61552c71184ca7021a6b1737dbd7b35ae77fd19 /home/wolfy/unpaper-0_2.tgz - package compiles on devel (x86_64) - no BR at all (just gcc which is in exception list) - no locales - not relocatable - owns all files and directories that it creates, does not take ownership of foreign files/directories - no duplicate files - permissions ok - %clean ok - macro use consistent - code, not content - no need for -docs - nothing in %doc affects runtime - not a GUI, so no need for .desktop file - no .la / static/ .pc files SHOULD - package builds fine in mock / devel /x86_64 - works OK (from gscan2pdf ...) package APPROVED -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review