https://bugzilla.redhat.com/show_bug.cgi?id=915923 Dan Horák <dan@xxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |dan@xxxxxxxx Assignee|nobody@xxxxxxxxxxxxxxxxx |dan@xxxxxxxx Flags| |fedora-review? --- Comment #5 from Dan Horák <dan@xxxxxxxx> --- formal review is here, see the notes explaining OK* and BAD statuses below: OK* source files match upstream: a234427a0b9172aa8d1064577a5a1e9f4a86c839 qtxmlpatterns-opensource-src-5.0.2.tar.xz OK package meets naming and versioning guidelines. OK specfile is properly named, is cleanly written and uses macros consistently. OK dist tag is present. OK license field matches the actual license. OK* license is open source-compatible. License texts not included in package. OK* latest version is being packaged. OK BuildRequires are proper. OK compiler flags are appropriate. OK package builds in mock (Rawhide/x86_64). OK debuginfo package looks complete. OK* rpmlint is silent. OK final provides and requires look sane. N/A %check is present and all tests pass. OK shared libraries are added to the regular linker search paths, with correct scriptlets Ok owns the directories it creates. OK doesn't own any directories it shouldn't. OK no duplicates in %files. OK file permissions are appropriate. OK correct scriptlets present. OK code, not content. OK documentation is small, so no -docs subpackage is necessary. OK %docs are not necessary for the proper functioning of the package. OK headers in devel subpackage OK pkgconfig files in devel subpackage OK no libtool .la droppings. OK not a GUI app. - the Source URL doesn't work with the 5.0 series being in the archive - please include the license text in the package - I see 5.1 as the latest, but let's don't mix 5.1 with 5.0 during the review phase - rpmlint complains a bit, but the warnings are harmless qt5-qtxmlpatterns.src:42: W: macro-in-comment %{_bindir} qt5-qtxmlpatterns-debuginfo.x86_64: W: hidden-file-or-dir /usr/src/debug/qtxmlpatterns-opensource-src-5.0.2/src/xmlpatterns/.rcc qt5-qtxmlpatterns-debuginfo.x86_64: W: hidden-file-or-dir /usr/src/debug/qtxmlpatterns-opensource-src-5.0.2/src/xmlpatterns/.rcc qt5-qtxmlpatterns-debuginfo.x86_64: W: hidden-file-or-dir /usr/src/debug/qtxmlpatterns-opensource-src-5.0.2/src/xmlpatterns/.moc qt5-qtxmlpatterns-debuginfo.x86_64: W: hidden-file-or-dir /usr/src/debug/qtxmlpatterns-opensource-src-5.0.2/src/xmlpatterns/.moc qt5-qtxmlpatterns-devel.x86_64: W: no-documentation qt5-qtxmlpatterns-devel.x86_64: W: no-manual-page-for-binary xmlpatterns-qt5 qt5-qtxmlpatterns-devel.x86_64: W: no-manual-page-for-binary xmlpatternsvalidator-qt5 qt5-qtxmlpatterns.x86_64: W: no-documentation 4 packages and 0 specfiles checked; 0 errors, 9 warnings. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=NXtVOTO1Pd&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review