Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: libtheora https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226048 michel.salim@xxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |michel.salim@xxxxxxxxx ------- Additional Comments From michel.salim@xxxxxxxxx 2007-03-18 20:11 EST ------- Almost ready for approval (see Maybe and Bad section) Good: - Package name matches upstream - Spec file name matches base package name - License matches actual license, included in %doc, is FLOSS - Spec written in American English, is legible - Source matches upstream - Package builds fine on all supported architectures - Build requirements complete - ldconfig called properly - directory ownerships OK - files listing: no duplicates - file permissions OK - Inter-dependencies OK Maybe: - Why --enable-static=yes ? Bad: - rpmlint: E: libtheora invalid-version 1.0alpha7 according to the Naming Guidelines, the 'alpha' part should be part of the release tag W: libtheora-devel summary-ended-with-dot E: theora-tools binary-or-shlib-defines-rpath No documentation for libtheora-devel and theora-tools, but that's fine - Source URL not provided. Also, use .tar.bz2 instead of .tar.gz? -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review