https://bugzilla.redhat.com/show_bug.cgi?id=994552 Rex Dieter <rdieter@xxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #4 from Rex Dieter <rdieter@xxxxxxxxxxxx> --- 1. better url, https://projects.kde.org/projects/kde/kdesdk/dolphin-plugins 2. SHOULD drop unused BuildRequires: desktop-file-utils naming: ok licensing: ok macros: ok scriptlets: n/a 3. dependencies: hrm, since these are dolphin plugins, probably ought to add a dependency on it, something like: Requires: dolphin%{?_kde4_version: >= %{_kde4_version}} (dolphin is currently a virtual provides in kde-baseapps) these items are largely cosmetic, and can be fixed post-review. APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=YxrYoTvgZN&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review