https://bugzilla.redhat.com/show_bug.cgi?id=994429 Rex Dieter <rdieter@xxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #2 from Rex Dieter <rdieter@xxxxxxxxxxxx> --- naming: ok 1. license not ok, I see GPLv2 code + GFDL docs, so License: GPLv2 and GFDL and add %doc COPYING.DOC macros: ok scriptlets ok obsoletes/provides: ok 2. better url: https://projects.kde.org/projects/kde/kdesdk/kcachegrind as items 1,2 are mostly cosmetic, can be fixed post-review APPROVED -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Oi7QcdLuhp&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review