https://bugzilla.redhat.com/show_bug.cgi?id=994399 Rex Dieter <rdieter@xxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #1 from Rex Dieter <rdieter@xxxxxxxxxxxx> --- naming: ok 1. license: not ok, there are also GFDL docs, # most code GPLv2+, cvsservice LGPLv2+, docs GFDL License: GPLv2+ and LGPLv2+ and GFDL and add to %files %doc COPYING COPYING.DOC macros: ok scriplets: ok 2. better url tag: https://projects.kde.org/projects/kde/kdesdk/cervisia obsoletes/provides: ok items 1,2 are mostly cosmetic, can be fixed post-review. APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=pcpYiNriXR&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review